Repository navigation
Fix CI and drop vm2 from the dependency tree - #1515
Merged
Merged
Conversation
- Remove google/wireit@setup-github-actions-caching/v1. It talks to the
legacy GitHub Actions cache service, which now rejects every request
("GitHub Cache check HTTP 400"), failing the build, check and tests jobs
before they do any work.
- Remove docker-practice/actions-setup-docker, which fails to install
Docker on current ubuntu-latest runners. Docker and the Compose v2
plugin are preinstalled, so build:docker/start:docker now use
`docker compose` instead of the standalone `docker-compose` binary.
- Bump actions/checkout and actions/setup-node to v4.
node:18.12-slim is based on Debian 11 (bullseye), whose security archive no longer serves the packages its apt index references, so `apt install default-jre` in the firestore-emulator image fails with 404s. Use node:18.20.8-bookworm-slim (Debian 12) for all three images so they share the same Node version.
firebase-tools 11.x pulls in vm2 through proxy-agent@5 -> pac-proxy-agent@5 -> pac-resolver@5 -> degenerator@3. vm2 has multiple critical sandbox-escape advisories (e.g. CVE-2026-43997, CVE-2026-26332, CVE-2026-44006, CVE-2026-24781, CVE-2026-24118, CVE-2026-44005). firebase-tools >= 12.4.5 depends on proxy-agent@^6.3.0, which resolves to degenerator@5, and degenerator@5 no longer depends on vm2. 13.35.1 is the latest 13.x and still supports Node 18 (which CI and the Docker images use). firebase-tools is only used as a dev tool here, to run the Firestore emulator for catalog-server.
Fixes the zizmor unpinned-uses findings from the GitHub Actions Scan required workflow, and the excessive-permissions warnings by setting contents: read at the workflow level.
kevinpschaaf
approved these changes
Oct 29, 2026
rictic
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
because of retired GitHub Actions and an outdated Docker base image.
vm2(CVE-2026-43997, CVE-2026-26332, and others) by bumpingfirebase-toolsto^13.35.1, which keeps Node 18 support.tests that run the Firestore emulator on the new
firebase-tools:https://github.com/smalls/webcomponents.org/actions?query=branch%3Afix-ci-remove-vm2
This covers the
vm2part of #1512, #1510, #1504, and #1501.