Skip to content

Fix CI and drop vm2 from the dependency tree #1515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rictic merged 4 commits into from
Oct 29, 2026
+9,768 −11,501
Merged

Fix CI and drop vm2 from the dependency tree #1515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3ae06ff
Fix CI: drop retired wireit GitHub cache action, use built-in Docker
smalls Oct 29, 2026
587304a
Docker: move base images from bullseye to bookworm
smalls Oct 29, 2026
4e0b6e7
Bump firebase-tools to ^13.35.1 to drop vm2
smalls Oct 29, 2026
2221be6
CI: pin actions to commit SHAs and restrict token permissions
smalls Oct 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,23 +2,24 @@ name: Build

on: [push, pull_request]

permissions:
contents: read

jobs:
build-local:
runs-on: ubuntu-latest
env:
WIREIT_FAILURES: continue

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@11d5960a326750d5838078e36cf38b85af677262 # v4.4.0

- uses: actions/setup-node@v3
- uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
with:
node-version: 18
cache: npm
cache-dependency-path: package-lock.json

- uses: google/wireit@setup-github-actions-caching/v1

- name: NPM install
run: npm ci

Expand All @@ -29,14 +30,11 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@11d5960a326750d5838078e36cf38b85af677262 # v4.4.0

- uses: actions/setup-node@v3
- uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
with:
node-version: 18

- name: setup-docker
uses: docker-practice/actions-setup-docker@1.0.11

- name: Build Docker
run: npm run build:docker
9 changes: 5 additions & 4 deletions .github/workflows/check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,23 +2,24 @@ name: Check

on: [push, pull_request]

permissions:
contents: read

jobs:
check:
runs-on: ubuntu-latest
env:
WIREIT_FAILURES: continue

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@11d5960a326750d5838078e36cf38b85af677262 # v4.4.0

- uses: actions/setup-node@v3
- uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
with:
node-version: 18
cache: npm
cache-dependency-path: package-lock.json

- uses: google/wireit@setup-github-actions-caching/v1

- name: NPM install
run: npm ci

Expand Down
9 changes: 5 additions & 4 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,23 +2,24 @@ name: Tests

on: [push, pull_request]

permissions:
contents: read

jobs:
tests:
runs-on: ubuntu-latest
env:
WIREIT_FAILURES: continue

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@11d5960a326750d5838078e36cf38b85af677262 # v4.4.0

- uses: actions/setup-node@v3
- uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
with:
node-version: 18
cache: npm
cache-dependency-path: package-lock.json

- uses: google/wireit@setup-github-actions-caching/v1

- name: NPM install
run: npm ci

Expand Down
2 changes: 1 addition & 1 deletion docker/catalog/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Official lightweight Node.js image
# https://hub.docker.com/_/node
FROM node:18.12-slim
FROM node:18.20.8-bookworm-slim

# Arbitrary but conventional working directory
WORKDIR /usr/src/app
Expand Down
2 changes: 1 addition & 1 deletion docker/firestore-emulator/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Official lightweight Node.js image
# https://hub.docker.com/_/node
FROM node:18.12-slim
FROM node:18.20.8-bookworm-slim

# Arbitrary but conventional working directory
WORKDIR /usr/src/app
Expand Down
2 changes: 1 addition & 1 deletion docker/site/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Official lightweight Node.js image
# https://hub.docker.com/_/node
FROM node:18.12-slim
FROM node:18.20.8-bookworm-slim

# Arbitrary but conventional working directory
WORKDIR /usr/src/app
Expand Down
Loading
Loading