Support prototype-named component store keys - #8347
Open
OskarEichler wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The component Store keeps five public component-name/ID registries in ordinary objects. Names such as
toStringand__proto__therefore resolve inherited values: lazy registration can be skipped, unregistered props/instances/wrapped components appear present, and normal store/retrieve operations return incorrect data.Fix
Initialize all five key registries without Object prototypes. This preserves the existing string-key API and constant-time lookups while making every public component name and ID an independent own key.
Breaking changes
None. Previously broken names now behave like ordinary component names and IDs.
Test plan
toStringand__proto__regressions covering initial absence and normal store/retrieve behavior for props, component providers, instances, and wrapped components.yarn test-jspasses: 38 suites, 397 tests; 11 suites/59 tests remain intentionally skipped.git diff --checkpass.