Skip to content

Support prototype-named component store keys #8347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OskarEichler wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support prototype-named component store keys #8347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions src/components/Store.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,28 @@ describe('Store', () => {
expect(uut.getComponentClassForName('example.mycomponent')).toEqual(MyWrappedComponent);
});

it.each(['toString', '__proto__'])('treats %s as a regular store key', (key) => {
expect(uut.getPropsForId(key)).toEqual({});
expect(uut.getComponentClassForName(key)).toBeUndefined();
expect(uut.getComponentInstance(key)).toBeUndefined();
expect(uut.hasRegisteredWrappedComponent(key)).toBe(false);

const ComponentClass = () => class MyComponent extends React.Component {};
const componentInstance = {} as IWrappedComponent;
class WrappedComponent extends React.Component {}

uut.updateProps(key, { foo: 'bar' });
uut.setComponentClassForName(key, ComponentClass);
uut.setComponentInstance(key, componentInstance);
uut.setWrappedComponent(key, WrappedComponent);

expect(uut.getPropsForId(key)).toEqual({ foo: 'bar' });
expect(uut.getComponentClassForName(key)).toBe(ComponentClass);
expect(uut.getComponentInstance(key)).toBe(componentInstance);
expect(uut.hasRegisteredWrappedComponent(key)).toBe(true);
expect(uut.getWrappedComponent(key)).toBe(WrappedComponent);
});

it('clear props by component id when clear component', () => {
uut.updateProps('refUniqueId', { foo: 'bar' });
uut.clearComponent('refUniqueId');
Expand Down
10 changes: 5 additions & 5 deletions src/components/Store.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@ import { ComponentProvider } from 'react-native';
import { IWrappedComponent } from './ComponentWrapper';

export class Store {
private componentsByName: Record<string, ComponentProvider> = {};
private propsById: Record<string, any> = {};
private pendingPropsById: Record<string, any> = {};
private componentsInstancesById: Record<string, IWrappedComponent> = {};
private wrappedComponents: Record<string, React.ComponentClass<any>> = {};
private componentsByName: Record<string, ComponentProvider> = Object.create(null);
private propsById: Record<string, any> = Object.create(null);
private pendingPropsById: Record<string, any> = Object.create(null);
private componentsInstancesById: Record<string, IWrappedComponent> = Object.create(null);
private wrappedComponents: Record<string, React.ComponentClass<any>> = Object.create(null);
private lazyRegistratorFn: ((lazyComponentRequest: string | number) => void) | undefined;

updateProps(componentId: string, props: any, callback?: () => void) {
Expand Down