Add ML-KEM and ML-DSA support by aidangarske · Pull Request #399 · wolfSSL/wolfProvider

aidangarske · 2026-05-23T05:56:36Z

ML-KEM (FIPS 203) and ML-DSA (FIPS 204) via wolfSSL backend.

Algorithms: ML-KEM-512/768/1024, ML-DSA-44/65/87 hybrid schemes supported now as well

Opt-in: ./scripts/build-wolfprovider.sh --enable-pqc (adds --enable-mlkem --enable-mldsa to wolfSSL).

PQC is not auto detected its only enabled when specifically built.
Ability to enable either algo only or both
Reject pqc with debian bookworm build could test with trixie eventually
ML-DSA CertificateVerify signing and verification both work in TLS
wolfProvider now generates ML-DSA certs
wolfProvider X509 ML-DSA sigs are valid
osp integration with https://github.com/open-quantum-safe/oqs-demos/tree/main/nginx using ML-DSA and hybrid schemes and tested in CI

Validation: three independent paths cross-checked, all pass.

Internal unit tests (11 functions x 3 levels = 33 assertions) in make test
wolfProvider <-> OpenSSL 3.6+ default provider (12 cross-pairs)
wolfProvider <-> wolfSSL direct wc_* API (12 cross-pairs)
entire openssl mldsa mlkem test suite exercised in CI for full compatibility
Interop tests with hybrid in place as well

CI: new wolfssl-versions-pqc.yml runs three matrix rows - pre-PQC wolfSSL, latest stable, master -- and the three-way interop validator on the PQC-enabled rows.

Put floor to 3.6 where mldsa apis solid and 5.9.2 for pqc in general; added note that we could do lower than 3.6 if reuqested but offically support and test those higher versions

supplemental PR for interop test in wolfCrypt: wolfSSL/wolfssl#10603

Test plan

make test passes (all 11 PQC tests + existing suite)
./test/pqc_interop.test -- ALL PASS (24 cross-pairs)
Build against pre-PQC wolfSSL: PQC code paths skip, make test clean
CI green on all three matrix rows

…tion honoring

Frauschi

Some smaller findings. The biggest "issue" imo is the usage of the now old ML-DSA API instead of the new one. But moving this to the new one should be easy.

Frauschi · 2026-05-27T11:45:49Z

Jenkins retest this please

aidangarske · 2026-05-30T00:16:08Z

Jenkins retest this please

…, get_params, KEM op name, debian pqc)

Frauschi

LGTM

…arams, and WP_LOG_COMP_PQC tracing

…) with version-floor gates and per-algorithm CI coverage

…vp_test (replace-default uses no-tests)

…y support for TLS 1.3 key exchange

…r1MLKEM1024)

…fault, both directions, all ML-KEM and hybrid groups)

…rts load through wolfProvider

…rts authenticate in TLS 1.3

… sign ML-DSA certificates

…idate as trust anchors (EVP_PKEY_is_a / check_sig_alg_match)

…Test::Nginx harness (wolfSSL stable+master, latest OpenSSL, force-fail, pinned nginx/nginx-tests)

…d for oqs-provider, exercising ML-DSA auth + ML-KEM/hybrid KEX via their connection test

…hybrid-group KEM; run all PQC unit tests in CI

…ify per group), validating the ML-DSA TLS signature algorithm end-to-end

…pply FIPS 204 sig params in all init paths, reject wrong-length keygen seed, close hybrid match fail-open

…t, reject wrong-length IKME/test-entropy, scrub hybrid shared secret on failure, fix fill_rnd log flag

…erive ECC public on hybrid private import, scrub ML-KEM shared secret on failure

…dersized buffer (early-return on size check), reject mismatched public on hybrid keypair import

…A public only when actually decoded, give hybrid variant tables internal linkage

…on-zero length

… flakes

….9.2); fix wget TLS by setting LD_LIBRARY_PATH after nginx download

…rray of GIDs, so the loop ran once with a GID); drop install-layout-dependent mime.types include; add startup debug

…per wolfSSL ref), loading wolfProvider via provider.conf in non-replace builds

aidangarske added 7 commits May 22, 2026 22:08

Add PQC scaffolding: ML-KEM/ML-DSA macros, names, externs, build flag

aad005d

Add ML-KEM keymgmt and KEM dispatch for 512/768/1024

d203979

Add ML-DSA keymgmt and signature dispatch for 44/65/87

be25627

Add ML-KEM and ML-DSA unit tests + dupctx buffer copy fix

3df1a6f

Add PQC version-compat CI: pre-PQC, latest stable, master

f78fdb8

Add FIPS 204 ctx mode for ML-DSA + three-way interop validator in CI

c1b7c10

Add ML-KEM and ML-DSA raw key import/export roundtrip tests

60f2cd6

Copilot AI review requested due to automatic review settings May 23, 2026 05:56

Copilot started reviewing on behalf of aidangarske May 23, 2026 05:56 View session

This comment was marked as resolved.

Sign in to view

aidangarske added 2 commits May 22, 2026 23:11

Gate PQC macros on header availability via __has_include

dae5cd6

Address Copilot review + dynamic wolfSSL version matrix with PQC floor

0aec54f

aidangarske self-assigned this May 23, 2026

aidangarske added 7 commits May 22, 2026 23:47

Document ML-KEM and ML-DSA support in README and integration guide

618ad0a

Address Skoll review: input validation, consistency checks, dup selec…

39e677c

…tion honoring

Run PQC version matrix on draft PRs too (match wolfTPM behavior)

ef9ac48

Use wc_mlkem.h (mlkem.h removed on wolfssl master); drop absence check

ed58142

CI: diagnose OpenSSL default provider PQC support

0b04e5a

interop: use global lib ctx for default provider side (CI lib ctx fix)

371c4e6

CI: include lib64 in LD_LIBRARY_PATH so Linux finds the local libcrypto

f69c064

aidangarske marked this pull request as ready for review May 26, 2026 17:13

aidangarske requested review from ColtonWilley and Frauschi May 26, 2026 17:13

Frauschi requested changes May 27, 2026

View reviewed changes

PQC: canonical ML-KEM/ML-DSA APIs + address review feedback

c2bd794

aidangarske requested a review from Frauschi May 29, 2026 23:43

PQC: address skoll review (empty msg, NULL-key reinit, KEM mixed-NULL…

ec3e26d

…, get_params, KEM op name, debian pqc)

Frauschi previously approved these changes Jun 1, 2026

View reviewed changes

padelsbach reviewed Jun 4, 2026

View reviewed changes

Comment thread src/wp_mldsa_kmgmt.c

Comment thread src/wp_mldsa_kmgmt.c

Comment thread src/wp_mlkem_kmgmt.c

Comment thread test/standalone/tests/pqc_interop/test_pqc_interop.c

Add PQC OpenSSL-vector KAT CI, ML-DSA message API, seed/ikme keygen p…

8f4e35c

…arams, and WP_LOG_COMP_PQC tracing

aidangarske mentioned this pull request Jun 5, 2026

PQC enforce modulus and eta range checks in DecodePrivateKey wolfSSL/wolfssl#10603

Open

aidangarske added 20 commits June 4, 2026 20:13

Make ML-KEM/ML-DSA opt-in (--enable-pqc/--enable-mlkem/--enable-mldsa…

343d15c

…) with version-floor gates and per-algorithm CI coverage

KAT CI: add --enable-openssl-test so replace-default builds OpenSSL e…

164174c

…vp_test (replace-default uses no-tests)

Add pure ML-KEM TLS groups (MLKEM512/768/1024) with encoded-public-ke…

c0e556f

…y support for TLS 1.3 key exchange

Add hybrid PQC TLS groups (X25519MLKEM768, SecP256r1MLKEM768, SecP384…

9a91a59

…r1MLKEM1024)

PQC interop: add TLS 1.3 handshake group interop (wolfProvider <-> de…

ef4602c

…fault, both directions, all ML-KEM and hybrid groups)

Add ML-DSA encoder/decoder (PEM/DER SPKI+PKCS8) so ML-DSA keys and ce…

8b190ba

…rts load through wolfProvider

Register ML-DSA TLS signature algorithms (mldsa44/65/87) so ML-DSA ce…

f19fb30

…rts authenticate in TLS 1.3

Provide ML-DSA X509 signature AlgorithmIdentifier so wolfProvider can…

f2c1a1f

… sign ML-DSA certificates

Register ML-DSA keymgmt OID/short-name aliases so ML-DSA CA certs val…

2a43b3d

…idate as trust anchors (EVP_PKEY_is_a / check_sig_alg_match)

Add nginx PQC OSP CI: ML-DSA cert auth + ML-KEM/hybrid KEX via nginx …

fe77e16

…Test::Nginx harness (wolfSSL stable+master, latest OpenSSL, force-fail, pinned nginx/nginx-tests)

nginx PQC OSP: run oqs-demos nginx in Docker with wolfProvider swappe…

6c9e411

…d for oqs-provider, exercising ML-DSA auth + ML-KEM/hybrid KEX via their connection test

Add unit tests for ML-DSA encoder/decoder, ML-DSA X.509 signing, and …

e4f1839

…hybrid-group KEM; run all PQC unit tests in CI

PQC interop: add ML-DSA certificate TLS authentication test (sign+ver…

282e5ec

…ify per group), validating the ML-DSA TLS signature algorithm end-to-end

PQC security review fixes: zeroize seed/entropy/randomizer on free, a…

dc2cd4f

…pply FIPS 204 sig params in all init paths, reject wrong-length keygen seed, close hybrid match fail-open

PQC security review round 2: apply+validate keygen seed params at ini…

31bd1df

…t, reject wrong-length IKME/test-entropy, scrub hybrid shared secret on failure, fix fill_rnd log flag

PQC security review round 3: use sigSize as authoritative capacity, d…

368f26b

…erive ECC public on hybrid private import, scrub ML-KEM shared secret on failure

PQC security review round 4: fix ML-KEM KEM out-of-bounds scrub on un…

0c27517

…dersized buffer (early-return on size check), reject mismatched public on hybrid keypair import

PQC security review round 5: copy IKME on KEM dupctx, advertise ML-DS…

49260ae

…A public only when actually decoded, give hybrid variant tables internal linkage

PQC security review round 6: reject NULL ML-DSA message update with n…

0f9d2a5

…on-zero length

nginx PQC test: lengthen HTTP response wait to avoid handshake-timing…

32ff44d

… flakes

aidangarske requested a review from SparkiDev June 5, 2026 22:16

aidangarske added 3 commits June 5, 2026 19:48

nginx PQC CI: skip pre-PQC-floor wolfSSL stable (master-only until v5…

009a00c

….9.2); fix wget TLS by setting LD_LIBRARY_PATH after nginx download

nginx PQC test: rename GROUPS->KEX_GROUPS (GROUPS is a bash special a…

fd9083b

…rray of GIDs, so the loop ran once with a GID); drop install-layout-dependent mime.types include; add startup debug

nginx PQC: add replace-default/non-replace as a matrix axis (4 modes …

39fa5d2

…per wolfSSL ref), loading wolfProvider via provider.conf in non-replace builds

aidangarske removed request for ColtonWilley and anhu June 6, 2026 03:55

aidangarske assigned SparkiDev Jun 6, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ML-KEM and ML-DSA support#399

Add ML-KEM and ML-DSA support#399
aidangarske wants to merge 43 commits into
wolfSSL:masterfrom
aidangarske:pqc-support

aidangarske commented May 23, 2026 •

edited

Loading

Uh oh!

This comment was marked as resolved.

Uh oh!

Frauschi left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Frauschi commented May 27, 2026

Uh oh!

aidangarske commented May 30, 2026

Uh oh!

Frauschi left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

aidangarske commented May 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test plan

Uh oh!

This comment was marked as resolved.

Uh oh!

Frauschi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Frauschi commented May 27, 2026

Uh oh!

aidangarske commented May 30, 2026

Uh oh!

Frauschi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

aidangarske commented May 23, 2026 •

edited

Loading