Repository navigation
Fix SLO KV consumer and process failure gate - #772
Closed
KirillKurdyukov wants to merge 1 commit into
Closed
KirillKurdyukov wants to merge 1 commit into
KirillKurdyukov wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #772 +/- ##
============================================
+ Coverage 75.47% 75.48% +0.01%
- Complexity 3755 3756 +1
============================================
Files 396 396
Lines 16842 16842
Branches 1780 1780
============================================
+ Hits 12711 12714 +3
+ Misses 3515 3513 -2
+ Partials 616 615 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consume the basic KV checks from
ydb-platform/ydb-java-examples#69 at the exact public
revision
68c06dfa5f09dea42613dc5eaffb0e4c456cfd51.Keep the four existing Query, JDBC, Spring Data JDBC and Spring Data JPA
workloads and build each role against its own SDK checkout. Remove the
baseline invocation's current-image fallback so a failed baseline source
build cannot silently run the current SDK instead. Enable the existing
init@v2process-error gate withfail_on_workload_error: true.This change touches only
.github/workflows/slo.yml. It does not change SDKcode, retry/deadline settings, the build helper API or metrics.
Verification
matrix rows, separate SDK roots, absent baseline fallback and true process
gate. The remainder is semantically identical to the base workflow.
Both role SDK library trees use
d854009; this proves consumption, not adifferent-version benchmark.
negative processes covering missing/stale/wrong payload and final SDK
errors across the four adapters. Healthy processes exit 0; negatives exit
1 and retain their cause.
helper shell-syntax checks. The one-file source-publication review passed.
https://github.com/ydb-platform/ydb-java-examples/actions/runs/38666103274
Attempt 1 hit a port collision in unchanged query-example setup; the
cancelled JDK jobs are not counted as passes.
Hosted SDK SLO has not yet run this consumer. Deliberately induced native
retry recovery and a two-version performance comparison are not claimed.
The examples prerequisite and this consumer remain separate, unmerged PRs.