Skip to content

glove-parity: functional relation carrier — out(rel) as a method (D-CMH-G1-4a) - #1514

Merged
AdaWorldAPI merged 3 commits into
mainfrom
ccr-9f3b8075-74u47l-rel
Oct 12, 2026
Merged

AdaWorldAPI merged 3 commits into
mainfrom
ccr-9f3b8075-74u47l-rel

Conversation

@AdaWorldAPI

Copy link
Copy Markdown
Owner

What

A method Glove now carries functional relations. Each one declares:

  • a key field on its own concept;
  • the target concept's glove;
  • where a call supplies the target's live plane and value lanes.

This is #1311's anchor rule, moved into the method layer. Relations that fan out are not covered here.

  • out(rel) → Cond::Reaches → Filter::Semijoin(fk, target live plane). As in Gremlin, a traverser whose edge leads nowhere is dropped. A dangling key and a key pointing at a dead row both fail.
  • out(rel).has(f, eq|neq) → Cond::Via → Filter::EqU32Via, negated for neq. The liveness test is emitted once per relation.
  • count() after the hop counts anchor rows, because the anchor does not move.
  • The following are refused by name:
    • a second hop (SecondHop)
    • values on the target (ValueThroughRelation)
    • dedup on the target (DedupThroughRelation)
    • where(method()) on the target (WhereThroughRelation)
    • in / both (FanOut)
  • Target fields bind against the target's own basis, claims and binder. Errors name them as relation.field. The key itself joins required.
  • A call names each target concept's population. A wrong or missing one is refused with CallError::ForeignUniverse.
  • R2IL gap: the fold band has VIA but no GATHER. A relation method on R2IL returns CallError::FrontendGap { R2il, "GATHER" }. Methods without relations still run on both frontends.

There is no new op in Quack, mask-risc or R2IL. The Gremlin text form (decl.rs) loads out(rel) too.

Evidence

crates/lance-graph-glove-parity/tests/relation.rs has 7 tests. The fixture is a synthetic line -billed_to-> partner pair with dangling keys, dead partners and dead lines. Every answer is checked against a row loop over the field text at n ∈ {1, 64, 65, 4097}.

Six disable runs each turned red the test that names the guard:

guard removed failing test
liveness test row oracle + lowering
neq negation row oracle
population check the_target_population_is_checked_at_the_call
key in required refusal + lowering
R2IL refusal r2il_names_the_missing_gather
emit liveness once per relation lowering

Removing the liveness test fails the oracle. So EqU32Via alone is not out(rel): it keeps rows whose target is dead.

Two existing refusal pins were updated because the behaviour changed:

  • in/both now return FanOut.
  • out(performed_by) on the SAP glove now composes, and preparation refuses it with UnknownRelation.

The crate suite passes, and clippy runs clean with -D warnings and fmt.

Board

Still open

Fan-out (in, M:N, E(), outE/inV) and the second hop are still unsupported. D-SAG-1-4's multi-hop dependency is still blocked on the second hop.

🤖 Generated with Claude Code

https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh


Generated by Claude Code

…hod (D-CMH-G1-4a)

A Glove carries Relations: a canonical key field, the target's glove, and
where a call supplies the target's live plane and value lanes. Cond::Reaches
(out(rel)) binds to Quack's Semijoin over the target's live plane, Cond::Via
(out(rel).has) adds EqU32Via. The anchor stays (#1311's rule). R2IL has no
GATHER and refuses by name; a call checks the target's population.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
@coderabbitai

coderabbitai Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

Next included review available in 54 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 62 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 68a6211b-615d-4b6e-bfe7-755f54d169d1

📥 Commits

Reviewing files that changed from the base of the PR and between 42fa2a3 and 4f73869.


📒 Files selected for processing (19)
  • .claude/board/STATUS_BOARD.md
  • .claude/board/entries/2026-10-12-functional-relation-carrier.md
  • .claude/board/entries/README.md
  • .claude/plans/gremlin-composable-algebra-v1.md
  • crates/lance-graph-glove-parity/examples/awareness_loop.rs
  • crates/lance-graph-glove-parity/examples/compose_cost.rs
  • crates/lance-graph-glove-parity/examples/method_cost.rs
  • crates/lance-graph-glove-parity/examples/method_load.rs
  • crates/lance-graph-glove-parity/src/awareness.rs
  • crates/lance-graph-glove-parity/src/decl.rs
  • crates/lance-graph-glove-parity/src/gremlin.rs
  • crates/lance-graph-glove-parity/src/method.rs
  • crates/lance-graph-glove-parity/tests/awareness.rs
  • crates/lance-graph-glove-parity/tests/common/mod.rs
  • crates/lance-graph-glove-parity/tests/declared.rs
  • crates/lance-graph-glove-parity/tests/gremlin.rs
  • crates/lance-graph-glove-parity/tests/method.rs
  • crates/lance-graph-glove-parity/tests/polyfill.rs
  • crates/lance-graph-glove-parity/tests/relation.rs

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.


Comment @coderabbitai help to get the list of available commands.

@AdaWorldAPI
AdaWorldAPI marked this pull request as ready for review October 12, 2026 19:29
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-12T19:31:46.683404Z 4f73869 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4f73869628

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/lance-graph-glove-parity/src/method.rs
@AdaWorldAPI
AdaWorldAPI merged commit 10325b3 into main Oct 12, 2026
12 checks passed
AdaWorldAPI pushed a commit that referenced this pull request Oct 12, 2026
A call names one population per target concept, so a method whose two
relations reach the same concept in different universes cannot say which
one each relation reads. Preparation now refuses it (ConflictingUniverse)
instead of keeping the first. Codex review on #1514.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
AdaWorldAPI added a commit that referenced this pull request Oct 12, 2026
glove-parity: refuse two populations of one relation target concept (#1514 follow-up)
AdaWorldAPI added a commit that referenced this pull request Oct 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants