Repository navigation
build: integrate published CDR generator (1/8) - #4247
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #4247 +/- ##
=======================================
Coverage 81.96% 81.97%
=======================================
Files 1657 1659 +2
Lines 154382 154462 +80
Branches 12992 12996 +4
=======================================
+ Hits 126537 126614 +77
- Misses 24244 24247 +3
Partials 3601 3601
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes 🚀 New features to boost your workflow:
|
TomCC7
added this pull request to stack #4253
September 21, 2026 17:24
This was referenced Oct 1, 2026
TomCC7
removed this pull request from stack #4253
October 1, 2026 07:57
TomCC7
added this pull request to stack #4372
October 1, 2026 07:58
This was referenced Oct 1, 2026
Contributor
There was a problem hiding this comment.
go2 replay realtime
Details
| Benchmark suite | Current: 8ab9ab3 | Previous: 13e4a21 | Ratio |
|---|---|---|---|
first frame wall |
9.499 s |
9.978 s |
0.95 |
first frame cpu |
20.307 s |
20.862 s |
0.97 |
run cpu |
32.042 s |
32.466 s |
0.99 |
run cpu (user) |
24.21 s |
25.213 s |
0.96 |
run cpu (system) |
7.832 s |
7.253 s |
1.08 |
peak memory |
2719.418 MB |
2717.016 MB |
1.00 |
peak threads |
397 threads |
406 threads |
0.98 |
disk read |
23.402 MB |
28.266 MB |
0.83 |
disk write |
11.297 MB |
11.234 MB |
1.01 |
network (transport) |
2714.792 MB |
2715.069 MB |
1.00 |
network (external rx) |
0.122 MB |
0.074 MB |
1.65 |
network (external tx) |
0.166 MB |
0.338 MB |
0.49 |
This comment was automatically generated by workflow using github-action-benchmark.
This was referenced Oct 20, 2026
paul-nechifor
approved these changes
Oct 20, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear project: Message Encoding Refactor
dimOS uses the published
dimos-cdrgen==0.1.0directly. The library owns parsing, generation, codecs, ownership checks and native build recipes. This PR adds SDK discovery, a C++ codec header adapter, one consumer test file, a short guide and Linux/macOS CI. Runtime transport changes and built-in message catalogs remain in later PRs.Validation
At
ee4feff4a967ea49c4d965a0ffba86fe9b811db2:fbe126e741c44e14ee1c23bb17a7e68e2b6a00d6with an additive merge commit. Resolved onlypyproject.tomlanduv.lock: preserves main'slcmpackage rename and retains the pinned generator. Every pre-existing locked package version/source is unchanged; six generator-related packages are added. Offline lock consistency and applicable conflict-file hooks pass.dimos-cdrgen[native]==0.1.0; both main and dedicated CI use the same test setup. The parent test environment remains free of pip/catkin_pkg afterward.DIMOS_OFFLINE=1also applies to provisioning the build tools.macOS was not run locally. The supplied failed job was inspected; replacement CI has not been polled or claimed green. This PR is open for review; merge approval is still required.
Ownership administration
The reviewer ownership requests remain open for maintainers. PyPI permission changes and package publication are outside this assistant's scope per the user's instruction; no administrative or publishing action was performed. Organization-source publication is also unchanged.
Downstream callers must migrate from
dimos_message_buildand genericdimos.message_codegenimports in their own PR scopes.File change summary
Diff against merged main
fbe126e741c44e14ee1c23bb17a7e68e2b6a00d6at the head above:The dependency category includes binary-classified
uv.lock, excluded from line counts. Total text changes: 334 additions and one deletion. The three Nix lock updates came from autofix.ci commit9e52cd0a; they are not generator implementation. No upstream.msgsnapshots or generated classes are checked in. Root conftest owns shared markers; the dedicated--noconftestcommands declare their marker locally.