Repository navigation
Conversation
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #4366 +/- ##
==========================================
- Coverage 82.25% 82.17% -0.08%
==========================================
Files 1670 1673 +3
Lines 156484 156726 +242
Branches 13130 13147 +17
==========================================
+ Hits 128710 128787 +77
- Misses 24257 24322 +65
- Partials 3517 3617 +100
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 16 files with indirect coverage changes 🚀 New features to boost your workflow:
|
TomCC7
marked this pull request as ready for review
October 21, 2026 00:17
TomCC7
requested review from
Dreamsorcerer,
aclauer,
leshy,
mustafab0,
paul-nechifor and
spomichter
as code owners
October 21, 2026 00:17
Contributor
[Medium impact] The change reaches DimOS installs and message-package builders. The confirmed problems affect maintainer generation and native packaging workflows and are non-blocking; neither establishes a security vulnerability. FindingsSummaryAdds built-in CDR messages under
The two maintainer-workflow issues do not block merging. Reviews (1) · Last reviewed commit: "docs(messages): document complete built-..." · Reviewed by Greptile |
paul-nechifor
previously approved these changes
Oct 21, 2026
paul-nechifor
previously approved these changes
Oct 21, 2026
TomCC7
force-pushed
the
cc/feat/cdr-message-packages
branch
from
October 21, 2026 04:39
9e0d7b3 to
0f3c1f6
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this adds
.msgdefinitions with cdrgen during package installation.dimos.messages, plus schemas and native source artifacts.dimos.msgsand business code unchanged.Flow: definitions → cdrgen → installed artifacts → runnable examples. Base:
main.How to test
From this PR's checkout, with
uvand a C++ compiler:uv venv .venv-msg-review --python 3.12 DIMOS_ALLOW_MISSING_COCKPIT=1 uv pip install --python .venv-msg-review/bin/python . .venv-msg-review/bin/python -I examples/message-package/demo_installed_wheel.pyThe example prints the generated message and schema directories and checks CDR round trips.
For Python → C++ → Rust → Python, install CMake and Rust/Cargo, then run:
uv pip install --python .venv-msg-review/bin/python 'dimos-cdrgen[native]==0.1.1' .venv-msg-review/bin/python -I examples/message-package/demo_native.pyThe native example checks
map/cpp/rustand the unchanged Header timestamp. Full instructions.DIMOS_ALLOW_MISSING_COCKPIT=1permits installation without prebuilt web assets. WIP: transport, SDK and business integration follow in later PRs.