Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
go2 replay realtime (arm64)
Details
| Benchmark suite | Current: 6752fac | Previous: 17fdb6b | Ratio |
|---|---|---|---|
peak memory |
1595.867 MB |
1589.477 MB |
1.00 |
peak threads |
351 threads |
350 threads |
1.00 |
network (transport) |
2724.728 MB |
2730.079 MB |
1.00 |
disk write |
1.695 MB |
1.707 MB |
0.99 |
instructions |
115.702 G |
115.497 G |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cc/feat/cdr-optin-transports #4651 +/- ##
===============================================================
Coverage ? 81.72%
===============================================================
Files ? 1657
Lines ? 155150
Branches ? 13091
===============================================================
Hits ? 126794
Misses ? 24711
Partials ? 3645
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated messages can cross the existing relay bridge as plain CDR with complete ROS2 schemas in the channel manifest. The browser SDK compiles those schemas with pinned Foxglove packages and shows decoded values without ROS or a separate browser message package. This is explicit opt-in; existing LCM/JSON channels and transport defaults remain unchanged.
Project: Message Encoding Refactor. Based on #4649; the recording drafts #4645/#4650 are siblings, not prerequisites.
Use it
Compose this with the producer of
measured_pose: Out[PoseStamped]and explicitly bind its CDR transport. Complete PoseStamped/Header/Time definitions come from the installed owner. Existing registered web encoders retain precedence.Manual browser test
From this checkout with Deno installed:
cd web/sdk deno task fixture --host 127.0.0.1Open
http://127.0.0.1:5174/demo_cdr.html. Select PoseStamped and both byte orders: fields and full embedded schemas are visible. Select image to see the actual two RGB pixels. This is a fixture viewer over actual Python-generated CDR packets, not a live robot/relay demonstration or a Rerun viewer. Walkthrough.File changes by responsibility
.msgsources.Validation and limits
At
d97c1949cab182cc6f0efc994f5db5019b27dd87: 259 Python checks, 408 SDK tests, 191 cockpit tests; strict typing on four Python sources and both frontend type checks/builds passed. All applicable configured hooks passed. Actual sandboxed Chromium decoded big-endian PoseStamped/schema and verified canvas RGB bytes[0,1,2,255,253,254,255,255]; actual screenshots were saved locally. This is automated acceptance, not human review.Malformed/truncated/trailing CDR fails decoding; conflicting manifest type identities are unsupported. A generic decoder does not implement typed map/camera/control panels. Rerun generated-type integration, image/cloud domain conversion and default blueprint cutover remain later implementation scopes. No terminal CI result, hardware acceptance or production readiness is claimed.
The current head
6752face4f50b163b6c3b8d6a3625be323208675adds only the installed-wheel test harness correction. The main wheel was built and all 259 Python checks also passed against that installed production code in isolated Python. Actual browser screenshot provenance remainsd97c1949; the screenshot was captured from that revision, with no human acceptance claim.