Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
go2 replay realtime (arm64)
Details
| Benchmark suite | Current: 70c08e8 | Previous: 17fdb6b | Ratio |
|---|---|---|---|
peak memory |
1607.637 MB |
1589.477 MB |
1.01 |
peak threads |
364 threads |
350 threads |
1.04 |
network (transport) |
2722.547 MB |
2730.079 MB |
1.00 |
disk write |
2.012 MB |
1.707 MB |
1.18 |
instructions |
116.83 G |
115.497 G |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
❌ 2 Tests Failed:
View the top 2 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rerun can subscribe explicitly to generated CDR channels and render PoseStamped/PointStamped without adding viewer methods to generated value classes. PoseStamped shows orientation axes and a text entity containing every Header/Pose field. Named frames and exact source nanoseconds are preserved; existing legacy discovery and transport defaults are unchanged.
Project: Message Encoding Refactor. Based on #4651; recording and domain/default cutover remain separate scopes.
Manual test
With this checkout installed normally into the active Python environment:
Use a new output path. The exact example sends an actual generated PoseStamped through discovery-disabled loopback Zenoh/CDR, saves a real RRD and refuses to overwrite existing data. The viewer opens with axes and complete fields side by side, on source time
2023-11-14T22:13:20.123456789. The demo explicitly anchors its map frame at the origin; runtime bridges retain the producer's named frame and require the existing TF tree to locate it.Runtime configuration
The producer uses its own matching transport instance. Bridge cleanup unsubscribes before stopping its owned transport, including failed startup. A source timeline is scoped to the incoming CDR message and cleared even when rendering fails. Zero source stamps remain zero. Walkthrough.
File changes by responsibility
Validation and limits
At
70c08e85f4954e021111e55a11c0a5d1d35651e1: 13 focused/compatibility checks passed, including the exact real example and no-overwrite case. Strict typing passes on the adapter, bridge and example; applicable configured hooks pass. The main wheel builds. Actual sandboxed Chromium displayed the RRD's axes, full fields and nanosecond source timeline without page errors; screenshot provenance is recorded separately. Automated acceptance is not human review.Only stamped geometry is covered in this slice. Generated TF/camera/cloud/map/domain adapters and default-blueprint cutover remain implementation work. No terminal CI result, hardware acceptance, Foxglove sign-in or production readiness is claimed.
The same 13 checks also passed against the built main wheel in isolated Python, with the installed package imported before loading checkout tests.