Repository navigation
Conversation
This was referenced Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear project: Message Encoding Refactor
RealSense now publishes generated Image, CameraInfo, PointCloud2, Imu and project-owned ImuInfo values with CDR. The handwritten ImuInfo fingerprint/encoder is removed. Python port types and Rust registry names agree, including
dimos_msgs/msg/ImuInfo.The native TF SDK adds optional
#[tf(decode = ..., encode = ...)]hooks. Existing bare#[tf], lookup and publish operations retain their behavior. RealSense selects canonical TFMessage CDR through these hooks; the generic SDK does not acquire a dependency on the built-in message catalog. Codec errors propagate, and one TF topic rejects mixed codec pairs.The self-contained RealSense flake pins SDK/configuration source
62b899b2d3b0d315988df7db25664264391fb4ea, archive SHA2568d920aba91b51ba63f18e4cd88cdfff95ff4f3aa2dfbb34f2ef209a59182c75c. It generates the same owner used by ordinary package builds. V4L2/RealSense crate hash keys now match the unchanged locked LCM transport source revision; no forked LCM code was changed.An installed SDK test also exposed a packaging defect: the SDK Cargo manifest declared an example whose source was omitted from the wheel. The wheel/sdist now carry that existing source unchanged. The fix is also published in its owning SDK layer #4649 at
6065e638b117f3fac565afde4e27aeeed4d35a4d. The SDK example is shipped byte-identically. No benchmark was executed, investigated or tuned. The existing ignored RealSense benchmark only received the field/codec substitutions required for the generated value types to compile.Dependent draft after #4656. ZED, downstream consumers, default-transport cutover and final cleanup remain later work. No camera worker main, device enumeration/capture, robot, installer, firmware tool or driver operation was run. No registry publication.
Validation
Published head:
a4313e544d0eb064a455bbbe5b1e5f503b788f63. Functional/package acceptance ran on9deac468ad978eaeba80bb29b384a19c6ab4ae10; the final two commits only align native hash metadata.ldconfigwas run.pip checkpassed. The wheel SHA256 is48e8a41295eb8d9caf3275c525f3d9f45a67f778f1e4d6d533e187b10a3ae524.Try it without a camera
The embedded walkthrough lists ports, artifacts and prerequisites. On a Nix development host:
For a repository developer with the checkout installed, Rust/C toolchains and librealsense available through pkg-config:
cargo test --manifest-path dimos/hardware/sensors/camera/realsense/rust/Cargo.toml \ --locked --bin realsense_native --jobs 2 -- tests:: --skip bench::The Nix command was not run locally. The Cargo regressions were run with the isolated official SDK build tree. They check encoding, normalized timestamps in both byte orders, calibration/projection, frame/color alignment and IMU pairing; they do not start capture. The existing floating-point graph-time API is retained; raw CDR uses generated Time fields.
File change summary
Three-dot diff from merge-base
5385ae1df08b5ae8091cdc2f4aee9002cf73acd6: 17 files, 603 additions and 155 deletions, excluding binary lockfile line counts. Parent #4656 also has later autofix commits; final stack alignment remains scheduled after the remaining slices.No generated message classes or upstream
.msgsnapshots are checked in.