Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depth2DepthCloud now receives generated CompressedImage, CameraInfo, PointCloud2 and TFMessage values and publishes generated PointCloud2 with CDR payloads. The output copies the exact source Header stamp. Public Python port names/configuration and the model/calibration pipeline remain unchanged; LCM and Zenoh remain transport choices.
Parent: #4667. Part of the message encoding refactor.
For an already prepared source checkout, run the software-only review checks without a camera, lidar or host-network changes:
Expected: 7 Python config cases, 13 Rust module/undistortion cases and 5 shared pointcloud cases. Rust's normal build embeds the upstream model resources pinned by depth2depth 0.4.1; these checks do not run inference. The first build needs its normal native toolchain/dependencies and model files, subsequent cached checks can use
--offline.Validated locally: those 25 focused cases; 42 combined installed-main-wheel cases with the actual production modules asserted to come from site-packages;
cargo check --locked --offline, all-target Clippy with-D warnings, compileddepth2depth_cloudbinary, one strict Python source, normal main wheel and default 198-packageuv pip check. Other applicable hooks pass. Wheel SHA25671dd088d20bd3fc74a70153d3a3d64d34325d33eab2d7424504fde9f4de5c266.Not validated: Nix build/lint (no
nixexecutable locally), Metal/TensorRT, live neural pipeline accuracy/throughput or hardware. The local native lint hook fails specifically because Nix is unavailable; the repository gate is retained. No benchmarks or CI polling performed. The existing native TF graph still uses floating-point seconds internally; cloud Header timestamps remain exact integers. Default encoding cutover and legacy retirement remain later slices.