Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add plain generated OccupancyGrid helpers for array/file input, read-only row-major views, rotated map coordinates and explicit Header timestamps. This prepares the mapping/navigation cutover without replacing the existing grid class or changing existing consumers yet.
Parent: #4668. Part of the message encoding refactor.
From an installed main-package wheel for this proposal, the generated value workflow is:
For a prepared checkout, run the focused checks with
python -m pytest --noconftest -o addopts='' -q dimos/msgs/test_occupancy.py dimos/msgs/nav_msgs/test_OccupancyGrid.py.Validation: 41 source cases pass, including the retained historical pointcloud fixture case. That project LFS archive was fetched once, SHA256 verified against its pointer (
245395d0c3e200fcfcea8de5de217f645362b145b200c81abc3862e0afc1aa7e,327201 bytes), and safely extracted (898117 bytes). Installed-main-wheel checks pass 40 cases with the generated production helper asserted to come from site-packages; the source-only fixture lookup case is deselected in that installed run. One production helper passes strict typing, applicable hooks pass, normal main wheel builds and the default 198-package environment passes pip check. Wheel SHA256ea88584c175a0fcb4735ba1133b7ae58abb9683491cdc86f788e933943d756bd.This layer does not switch mapping/navigation producers, default encoding or remove legacy recording/classes. No hardware, benchmark investigation or CI polling performed.