Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Existing gradient, Voronoi, inflation, smoothing, overlay and offline rectangle/XML algorithms now accept generated OccupancyGrid values. Each returns the same kind of value it receives, so current legacy callers keep their behavior while generated consumers can migrate independently. Generated results copy the complete Header and MapMetaData, including a map-load timestamp distinct from the source timestamp.
Parent: #4669. Part of the message encoding refactor.
Run this against the proposal's installed main package:
From a prepared checkout,
python -m pytest --noconftest -o addopts='' -q dimos/mapping/occupancy/test_generated_operations.pyruns 21 cases without assets or hardware.Validation: 68 source checks pass, including the unchanged pixel/XML golden regressions and retained historical pointcloud case; 61 installed-main-wheel checks pass with actual production modules asserted to come from site-packages (one source-data lookup case deselected). Seven existing project golden archives were fetched from LFS, each OID/hash/size verified and safely extracted. Four production files pass strict typing, applicable hooks pass, normal main wheel and default 198-package pip check pass. Wheel SHA256
7364348a02ce3a2455662f88ba55520e28d6bdba5e1c8084e3ed1249fb43b8ef.Default mapping/navigation producers and runtime encoding are not switched in this layer; legacy class retirement follows verified consumer migration. XML scene generation was tested as text only; no simulator/hardware run, benchmark investigation or CI polling.