Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CostMapper now consumes generated PointCloud2 and publishes generated OccupancyGrid. The existing pointcloud-to-grid functions also accept generated clouds while retaining legacy input/output behavior for unmigrated callers; the numeric kernels are shared. Generated output copies the original Header, including empty-cloud and zero/negative/epoch timestamps, instead of reconstructing source time from float seconds. The initial safe disc copies the read-only cell view before updating generated data.
Parent: #4670. Part of the message encoding refactor.
Run this with the proposal's installed main package:
From a prepared checkout, run
NUMBA_NUM_THREADS=2 OMP_NUM_THREADS=2 python -m pytest --noconftest -o addopts='' -o 'markers=self_hosted: optional project fixture case' -m 'not self_hosted' -q dimos/mapping/test_generated_costmapper.pyfor 21 checks without external assets or network. Including its threeself_hosted-marked project-data cases runs the existing apartment/big-office goldens through real CDR input/output. They use the PLY's original float64 point fields so fixture coordinates are not quantized before comparison.Validation: 24 source checks pass, including all three real-data goldens; 21 installed-main-wheel checks pass with actual production modules asserted to come from site-packages (three source-data cases deselected). Real RPC and CDR Module ports use
memq://, with owned teardown and event waits. Five existing project LFS archives were size/SHA256 verified before safe extraction; pointcloud archives total about 20.5 MB compressed,155.5 MB expanded. Two production files pass strict typing; applicable hooks, normal main wheel and default 198-package pip check pass. Wheel SHA256db99fa66ad30a73bd12c9567611a3001ad60b396faa607f4f7e6831471c6ac74.Numba reports that this environment's TBB interface is too old and disables that threading layer; numeric checks pass on the available fallback. No performance claim or benchmark investigation. The original legacy live-Moment module was not collected because it constructs a default-network transport at import. No hardware operation, host/network configuration changes or CI polling. The default encoding factory and remaining mapping producers are still separate cutover work.