Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ReplanningAStarPlanner now uses generated CDR values throughout its Module ports, Global/LocalPlanner, P/PD controllers and navigation specs. Odometry and clicked points become owned nested PoseStamped values with exact source Headers. Footprint clearing edits an owned occupancy array; empty paths retain the available source Header. Port names, RPC names, control gains, thresholds, planner state machine and scheduling remain intact.
Parent: #4677. Project: https://linear.app/dimensional/project/message-encoding-refactor-05a3ddb4af3e/overview
After installing this commit, this directly computes a command without actuating hardware:
For the actual SDK Module pub/sub path, from the dev checkout run:
python -m pytest --noconftest --import-mode=importlib -o addopts='' -q \ dimos/navigation/go2/replanning_a_star/test_generated_planner.py \ -k actual_planner_moduleThat acceptance uses actual CdrTransport/MemoryRPC memq ports and the compiled A*: costmap + odometry + goal → generated Path → rotation feedback → forward Twist → stop Bool → zero Twist. No fake Module/ports and no robot. It owns subscription, transport and thread cleanup.
Validation: 135 source and 135 installed-wheel checks, including 19 planner/controller/conversion checks and dependent A*/safety/rendering/resampling/operations regressions. Eleven production files pass strict typing; applicable hooks and normal main wheel build pass; the full default runtime environment passes pip check (198 packages). The exact Python snippet above passes against the installed wheel. Hardware, benchmark and GitHub CI results are not claimed. Default encoding factories and other navigation/robot consumers remain subsequent layers; explicit CDR bindings are still required in this layer.