Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MovementManager relays generated PointStamped/Twist/Bool values. Existing click limits, per-axis scaling, teleop priority/cooldown and NaN cancellation fallback remain intact. Cancellation Headers use wall-clock integer nanoseconds. TfPose reads the already-generated TF buffer, preserves the exact Header and measures stamp progress in integer nanoseconds while retaining the existing local monotonic age/backoff contract.
Parent: #4678. Project: https://linear.app/dimensional/project/message-encoding-refactor-05a3ddb4af3e/overview
After installing this commit, run this offline TF example:
For the actual movement Module pub/sub acceptance, from the dev checkout run:
python -m pytest --noconftest --import-mode=importlib -o addopts='' -q \ dimos/navigation/movement_manager/test_movement_manager.py \ -k actual_cdr_movement_portsIt uses real CdrTransport/MemoryRPC memq ports: teleop command → stop Bool + cancellation PointStamped + scaled command; nav stays suppressed during cooldown and resumes exactly at the boundary. All resources are owned and cleaned; no robot or fixed sleeps.
Validation: 23 source and 23 installed-wheel checks, strict typing of two production files, applicable hooks, normal main wheel build, full runtime pip check (198 packages). Exact Python example above passes against the installed main wheel. Tests include zero/negative/epoch stamps and epoch+1ns progress in the actual TF buffer. No hardware, benchmark or GitHub CI result is claimed. Other followers/native/robot consumers, default cutover and legacy retirement remain subsequent work.