Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopt the native SDK's exact timestamp metadata in the depth-cloud TF adapter. CDR TF at modern epochs previously crossed an
f64conversion and lost nanoseconds; decode and re-encode now retain the original signed nanosecond stamp. Inference, calibration, point-cloud math, ports and query APIs are unchanged.Project: https://linear.app/dimensional/project/message-encoding-refactor-05a3ddb4af3e/overview
Parent: #4684.
From this checkout with Rust installed:
cargo test --locked --manifest-path dimos/perception/depth2depth_cloud/rust/Cargo.toml --lib --jobs 2 cargo clippy --locked --manifest-path dimos/perception/depth2depth_cloud/rust/Cargo.toml --all-targets --jobs 2 -- -D warningsThe existing crate build embeds its pinned official CPU model files. For an offline build, set
DEPTH2DEPTH_MODEL_DIRto an already populated directory containing the two safetensors named and hashed in upstream depth2depth 0.4.1'smodel.json; no inference or hardware is run by these tests. Here both previously cached files were SHA256-verified and reused, with no new model download.Local evidence: 14 Rust unit tests pass, the same 14 pass from a standalone source layout with hash-verified SDK/generated-message artifacts and no checkout parent paths, all-target Clippy with warnings denied passes, binary builds, and applicable hooks pass. The existing generated-cloud exact-stamp regression and all other tests remain. The configured workflow already runs this crate's tests on Linux. No Python runtime/wheel content changes, so its unchanged installation gates were not repeated.
Nix is absent locally, so its gate remains unverified. The standalone Cargo proof exposed and fixes nested workspace membership in this flake; it does not substitute for a Nix build. SDK floating-point lookup query windows remain as before. No inference/GPU/robot, CI-polled, or human acceptance claim; remaining consumers/default/cleanup migration remains open.