Skip to content

refactor(navigation): render generated CDR paths and goals - #4686

Closed
TomCC7 wants to merge 2 commits into
cc/fix/cdr-depth-tf-stampsfrom
cc/feat/cdr-navigation-viz
Closed

TomCC7 wants to merge 2 commits into
cc/fix/cdr-depth-tf-stampsfrom
cc/feat/cdr-navigation-viz

Conversation

@TomCC7

@TomCC7 TomCC7 commented Oct 20, 2026

Copy link
Copy Markdown
Member

Navigation path/goal rendering now reads generated Path, nested PoseStamped.pose and PointStamped.point values, matching the migrated Python/native planner and movement ports. Geometry, color/profile rules, body placement, empty/veto behavior and renderer configuration stay the same.

Project: https://linear.app/dimensional/project/message-encoding-refactor-05a3ddb4af3e/overview

Parent: #4685.

Files Count Change
Rendering 2 Generated path/goal types, external quaternion yaw helper, canonical Header frame access
Tests 2 Original geometry/color/veto/pickle assertions ported; CDR roundtrip proves exact input stamps and immutability
CI 1 Installed-module provenance, exact renderer tests and scoped typing

From the configured Python development environment in this checkout:

python -m pytest --noconftest --import-mode=importlib -o addopts='' -q dimos/navigation/local_planner/test_viz.py dimos/navigation/global_planner/test_viz.py

Tests create actual Rerun archetypes and inspect their positions, body counts, colors and frames. They do not start a viewer or robot. Plain message construction explicitly supplies nested values and source stamps; deterministic microsecond-spaced test stamps replace implicit legacy wall-clock constructors.

Locally: 11 source tests and the same 11 using both production renderer modules from the installed main wheel pass; strict typing for 2 production files, applicable hooks, normal main-wheel build and the existing 198-package dependency check pass. Wheel SHA256: e52823cd90dc80903e245b9b48ec13b8836809bdbbbde56f6e5b9c3958cd8fc6.

This layer only changes path/goal rendering. Keyed ray-tracing and MLS region streams still carry legacy Header.seq metadata and require a separate explicit schema migration; their old renderer tests are retained. No screenshot/human visual acceptance, all-green CI or complete migration claim. CI was not polled.

@TomCC7 TomCC7 closed this Oct 20, 2026
@TomCC7
TomCC7 deleted the cc/feat/cdr-navigation-viz branch October 20, 2026 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant