Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Navigation path/goal rendering now reads generated
Path, nestedPoseStamped.poseandPointStamped.pointvalues, matching the migrated Python/native planner and movement ports. Geometry, color/profile rules, body placement, empty/veto behavior and renderer configuration stay the same.Project: https://linear.app/dimensional/project/message-encoding-refactor-05a3ddb4af3e/overview
Parent: #4685.
From the configured Python development environment in this checkout:
python -m pytest --noconftest --import-mode=importlib -o addopts='' -q dimos/navigation/local_planner/test_viz.py dimos/navigation/global_planner/test_viz.pyTests create actual Rerun archetypes and inspect their positions, body counts, colors and frames. They do not start a viewer or robot. Plain message construction explicitly supplies nested values and source stamps; deterministic microsecond-spaced test stamps replace implicit legacy wall-clock constructors.
Locally: 11 source tests and the same 11 using both production renderer modules from the installed main wheel pass; strict typing for 2 production files, applicable hooks, normal main-wheel build and the existing 198-package dependency check pass. Wheel SHA256:
e52823cd90dc80903e245b9b48ec13b8836809bdbbbde56f6e5b9c3958cd8fc6.This layer only changes path/goal rendering. Keyed ray-tracing and MLS region streams still carry legacy
Header.seqmetadata and require a separate explicit schema migration; their old renderer tests are retained. No screenshot/human visual acceptance, all-green CI or complete migration claim. CI was not polled.