Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The native MLS planner now consumes the generated CDR map/region streams from #4688 and publishes canonical
Path, surface regions and weighted edge regions. Seed pairing retains explicit region IDs; cylinder dimensions are read from named fields. Edge payloads are realLineSegment3Dvalues with a weight, replacing the legacy Path-shaped encoding.Project: https://linear.app/dimensional/project/message-encoding-refactor-05a3ddb4af3e/overview
Parent: #4688. Remaining SLAM/relocalization/robot/control/default/cleanup work is not included or claimed complete.
Manual synthetic mapper → MLS acceptance from this checkout with development Python dependencies and Rust installed:
This starts two actual native processes and a discovery-disabled localhost Zenoh router. Python supplies a synthetic floor cloud, TF and goal. Ray-tracing outputs feed MLS directly; the test requires a nonempty canonical route plus surface and weighted-edge regions, checks matching nested Headers and waypoint/weight values, and owns cleanup. Both binary variables are required; omitting them skips the native chain. No robot is operated.
Local evidence: 133 Rust unit tests (131 retained plus CDR edge/layout cases), the same 133 from a standalone artifact-only Cargo layout, all-target Clippy with warnings denied, native binary build and a real local PyO3 math wheel pass. All 15 focused Python tests pass from source and with production wrapper/transformer/rendering modules and the extension loaded from
site-packages. Strict typing for 4 production files, applicable hooks, main-wheel build and dependency check on the existing default environment plus mapper/MLS extensions pass. The existing goal/latch/search/replan/seed-priority rules remain unchanged. Python TF annotations/protocol now agree with the SDK's existing bidirectional#[tf]service.Main-wheel SHA256:
c0ea256a163e38cb1dcab5dac04f36d1802dd25df0639a1d69a0c162d3c2cf92. Optional MLS dev-profile wheel SHA256:897f7f3cd5423d69d0236cf1ebcb242de3e8ca3d0f190e6273257659d78179bb.Nix remains unverified because its executable is absent locally; standalone Cargo proves the source/dependency layout, not the Nix gate. TF query windows keep the existing floating-point API. Main wheel contains Python wrappers/SDK; installed native modules use explicitly supplied executables, while default Nix source builds remain checkout workflows. No CI polling/all-green, performance, hardware, screenshot or human acceptance claim.