Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated pose payloads now work with Observation metadata and
dimos map pose-fill. Standard nested PoseStamped, TransformStamped, PoseWithCovariance and Odometry inputs normalize to the existing indexed seven-value pose without loading or mutating the target payload. Static mounts use explicit transform composition. SQLite pose-fill preserves original CDR blobs and exact sensor Headers.Linear: https://linear.app/dimensional/project/message-encoding-refactor-05a3ddb4af3e/overview
Parent: #4689. This layer changes pose inputs only. Observation's legacy convenience output types and their remaining consumers will be migrated together in later layers.
Validation: 20 focused source tests and the same 20 installed-wheel tests pass; installed production modules asserted to come from site-packages. Two production files pass scoped strict mypy; applicable hooks pass; normal wheel builds and installed dependency check passes. Wheel SHA256:
133e2dac1643019397a6d369d16d9eedaeb35fc767ee68c792442adc832d3b3e.Manual review from this checkout after the ordinary development install:
python -m pytest --noconftest --import-mode=importlib -o addopts='' -q \ dimos/memory/type/test_observation.py \ dimos/mapping/cli/test_pose_fill.py \ dimos/memory/test_stream.py::TestWithPose \ dimos/memory/store/test_cdr_recording.pyThe SQLite case writes real canonical CDR streams, applies a separately timestamped pose, reopens both databases and checks the original bytes and nanosecond Header. No historical decoding fallback, hardware, network transport or benchmark run. CI has not been polled; no whole-stack completion claim.