Repository navigation
Conversation
This was referenced Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PGO, PGOAuto and PGOMap consume generated CDR PointCloud2 and TransformStamped values. Existing ISAM2 factors/noise, ICP settings, loop search, nearest-neighbor interpolation, vectorized drift correction, voxel carving and rebuild cooldown are retained. Per-point placement now changes XYZ on a copy while retaining organized layout, extra fields, per-point capture times, padding, endianness and the exact sensor Header. ICP's private downsampled submaps explicitly use geometry only.
Linear: https://linear.app/dimensional/project/message-encoding-refactor-05a3ddb4af3e/overview
Parent: #4690. The live PGO Module, map/replay CLI, Observation convenience outputs and remaining robot consumers are subsequent layers; this does not switch the default encoding.
Validation: 103 source and the same 103 installed-wheel tests pass; installed production module paths asserted to be site-packages. Real ICP recovers a known 6-DoF rigid motion on three synthetic walls. Real GTSAM map insertion retains exact sensor time. Six production files pass scoped strict mypy. Applicable hooks pass. Main wheel SHA256:
457d1eb1b0c66dad230f791ebf33001e842cbd98d71b6427c77231a9f6e27501.Manual functional review after the normal development install with the mapping extra:
OMP_NUM_THREADS=2 OPENBLAS_NUM_THREADS=2 python -m pytest \ --noconftest --import-mode=importlib -o addopts='' -q \ dimos/navigation/go2/loop_closure/test_pgo.py \ dimos/navigation/go2/loop_closure/test_pgo_auto.py \ dimos/navigation/go2/loop_closure/test_pgo_map.py \ dimos/mapping/voxels/test_stamped.py dimos/msgs/test_pointcloud.pyKnown pre-existing optional dependency metadata mismatch: GTSAM 4.3a1.post1 declares pytest>=9.0.1; this repository explicitly overrides it to pytest8.3.5. The functional checks use that repository override.
pip checkwith that optional test dependency reports the mismatch; it is not reported as clean. No dependency override or gate was added/relaxed here. Nix is unavailable locally; no Nix, benchmark, CI, device or whole-stack completion claim. No historical decoding fallback.