Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The live PGO mapper uses generated CDR PointCloud2/PoseStamped input and PointCloud2/PoseArray/weighted LineSegments3D/Float32 output. Port names, subscriptions, frame dropping, graph update conditions, telemetry options and PGO algorithms remain unchanged. Graph and map publications retain the lidar's exact source Header time.
Unitree stale-time repair accepts generated Header stamps alongside its existing Timestamped callers. Integer nanoseconds prevent adjacent valid captures from appearing stale through float rounding. A repaired generated message owns a copy; other subscribers retain the input bytes. The existing calibration window, stale extrapolation, frozen-firmware clock fallback and legacy caller mutation behavior are retained. The separate raw WebRTC conversion function still returns its old type pending the Go2 connection layer; this is not a wire fallback decoder.
Linear: https://linear.app/dimensional/project/message-encoding-refactor-05a3ddb4af3e/overview
Parent: #4692.
Validation: 10 source and the same 10 installed-wheel tests pass, two strict production files and applicable hooks pass. Actual Module ports use explicit
memq://LCM with local RPC IPC and real GTSAM. Installation paths asserted to be site-packages. Normal main wheel SHA256:e8c3bc1f698427b9f0e36d015dfb480c6b6788dbe3e38ee82eae7f3d18483711.Manual offline review after the normal development install with mapping dependencies:
The explicitly deselected
test_initreads the historical office_lidar recording; no historical decoding acceptance is claimed. The new integration creates synthetic input, subscribes to real output ports, checks known map/keyframe geometry and exact stamps, then owns all transport/Module cleanup. No robot, multicast network configuration, CI polling or benchmark execution. Known optional GTSAM pytest metadata mismatch remains as documented in #4691. Default cutover and the remaining robot/relocalization consumers are later layers.