Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relocalization reads
.pc2.cdrpremaps exported by #4692 and publishes generated TFMessage/TransformStamped and PointCloud2 values. The scanner window concatenates canonical clouds; the lidar aligner receives explicit Open3D geometry; Go2 merges the placed premap with its live map under the existing carving policy. Source cloud Headers/bytes are retained; accepted TF republications copy the fix and get the existing fresh publication time. Port names, matching thresholds, RANSAC/ICP parameters and once/retry/timer behavior remain unchanged.Linear: https://linear.app/dimensional/project/message-encoding-refactor-05a3ddb4af3e/overview
Parent: #4693. Offline relocalization replay/tuning utilities and their legacy recording fixtures are subsequent consumer layers. No legacy decoding fallback is added.
Validation: 14 source and the same 14 installed-wheel tests pass; installed module provenance asserted. Five production files pass scoped strict mypy; applicable hooks pass; normal wheel builds. SHA256:
f77a8337a0efc981c26071df16e362892e6215f32252d74be27f56e81bd93442.Manual offline review after installing the normal development dependencies:
OMP_NUM_THREADS=2 OPENBLAS_NUM_THREADS=2 python -m pytest \ --noconftest --import-mode=importlib -o addopts='' -q \ dimos/mapping/relocalization/test_module.pyThe CDR integration writes a real premap file, starts real Module ports on explicit memq, submits a canonical fix and checks received map/TF values, exact capture versus publication times and input ownership. Window tests use virtual time instead of sleeps. Merge tests run the real CPU voxel implementation with host GPU availability isolated at the external hardware boundary.
A newly exposed native dependency issue is repaired here: Open3D0.20 makes FPFH
indicesmandatory. The adapter explicitly selects every coarse point on0.20 and retains the two-argument API for older supported releases. Feature preparation was actually executed on0.20; older binary releases were not installed/retested. No matching parameter was tuned.The first merge acceptance attempt selected the production default GPU allocation on this host and timed out; the bounded command exited. CPU functionality is verified; GPU allocation/performance is not claimed. Production device defaults are unchanged. No benchmark investigation, CI polling, physical robot, host-network change or human acceptance. Nix and earlier external/optional dependency limitations remain separately documented in the stack.