Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Offline relocalization replay reads canonical PointCloud2/TFMessage recordings and
.pc2.cdrpremaps, then writes a canonical placedloaded_maponce. Existing attempt spacing, sparse-frame filtering, first accepted fix, post-fix recording window and numeric error calculations are retained. Explicit geometry helpers feed the existing native RayTrace/Open3D algorithms. Viewer palette registration, fine premap size and fixed probe colors live outside generated values.Linear: https://linear.app/dimensional/project/message-encoding-refactor-05a3ddb4af3e/overview
Parent: #4694. Tuning utilities receive encoding/geometry/display adapters only; no tuning study, search or benchmark was run or adjusted. The guide explicitly requires converted or regenerated canonical inputs. Renamed
.pc2.cdrfixture paths are not a claim that historical LFS files have already been converted.Validation: 23 focused source and the same 23 installed-wheel checks pass; production modules and the optional RayTrace extension asserted to come from site-packages. Five production files pass scoped strict mypy; applicable hooks pass; normal main wheel builds. SHA256:
e5b20c5be1818a4e53f388390738675b33e381a11c494a99cdc7c501974c50a0.Manual offline regression review requires the optional RayTrace Python math extension built in #4688 (it is not included as a precompiled native module in the main wheel):
The SQLite replay regression uses real generated cloud/TF payloads and the actual RayTrace math extension. The matcher decision is mocked at the external registration boundary so the test deterministically verifies refusal, retry, acceptance and stopping rather than running a tuning study. Placed-map tests check timestamp/frame/geometry, original input bytes and the existing no-overwrite behavior. No GPU/hardware, performance comparison, CI polling or human visual acceptance claim. Known GTSAM optional metadata mismatch, Nix and external gates remain separate; default cutover and legacy retirement are still incomplete.