Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated message types on the existing
WebRTCTransport.spec(channel, Type)andCloudflareTransportAPIs now use CDR inside the shared data-frame envelope. Type metadata demultiplexes a physical command channel; raw bytes and explicitly legacy types retain their separate codecs, without decoder fallback. No transport API or provider lifecycle change.Parent: #4707. Part of Message encoding refactor.
The installed serializer accepts arbitrary encapsulation prefixes. Reviewed LCM/Zenoh, WebRTC, WebXR-frame, CdrCodec and explicit converter entrypoints now require plain XCDR1 (either endianness) before field decoding. This is a scoped boundary fix, not a claim that every registry caller has been audited.
Validation at this commit: 247 source +247 installed-wheel tests, six production files strict mypy, applicable hooks, wheel build. Nix lint unavailable (
nixabsent). Installed store APIs also read all 4,451 stairs and 2,546 Go2-short previously converted real observations. Full current wheel SHA256:bfff105d72cd06652837498ad3c8fc2bb9d2aa899cb76d5c6ad192791d2dde7a.Offline manual check from a configured checkout (no broker or robot):
The WebRTC tests mock only the external provider; typed framing, registry codecs, multiplexing, malformed-frame recovery, wrong-class rejection, pickle/config sharing and sequence ownership run normally. Existing WebXR regressions run the shipped browser encoder offline with pinned Foxglove parsers. This is not live SFU/operator or hardware acceptance. No CI polling or benchmark result is claimed. Remaining hosted Go2/map/stats/recorder, simulation/robot graph closure and Gate B dependency retirement follow independently.