Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
go2 replay realtime (arm64)
Details
| Benchmark suite | Current: deecf9a | Previous: ecc2b8f | Ratio |
|---|---|---|---|
peak memory |
1602.242 MB |
1570.996 MB |
1.02 |
peak threads |
357 threads |
355 threads |
1.01 |
network (transport) |
2722.06 MB |
2730.387 MB |
1.00 |
disk write |
1.719 MB |
1.496 MB |
1.15 |
instructions |
115.629 G |
115 G |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
This was referenced Oct 20, 2026
This was referenced Oct 20, 2026
TomCC7
added this pull request to stack #4743
October 20, 2026 22:26
TomCC7
commented
Oct 21, 2026
TomCC7
force-pushed
the
cc/feat/cdr-unit-transports
branch
from
October 21, 2026 01:05
254cb8b to
2b46518
Compare
TomCC7
commented
Oct 21, 2026
TomCC7
commented
Oct 21, 2026
TomCC7
marked this pull request as ready for review
October 21, 2026 02:03
TomCC7
requested review from
Dreamsorcerer,
aclauer,
leshy,
mustafab0,
paul-nechifor and
spomichter
as code owners
October 21, 2026 02:03
TomCC7
commented
Oct 21, 2026
Contributor
[Medium impact] No outstanding findings block merging this PR. SummaryThis PR shares message codecs across LCM, Zenoh, and WebRTC. Generated messages use CDR; legacy messages keep their LCM format.
Reviews (2) · Last reviewed commit: "fix(transport): preserve native DDS type..." · Reviewed by Greptile |
Member
Author
|
@greptile review |
TomCC7
force-pushed
the
cc/feat/cdr-unit-transports
branch
from
October 21, 2026 04:39
23a3480 to
42b9f1f
Compare
TomCC7
force-pushed
the
cc/feat/cdr-unit-transports
branch
from
October 21, 2026 18:43
42b9f1f to
deecf9a
Compare
TomCC7
removed this pull request from stack #4743
October 22, 2026 18:51
TomCC7
added this pull request to stack #4776
October 22, 2026 18:52
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this adds
MessageCodecinterface with LCM and CDR implementations.Base: #4721. CDR serialization and type registration come from cdrgen. Transports retain their existing connection, subscription and QoS behavior.
Validation and limits
Tests cover codec round trips, invalid types and payloads, and existing transport behavior. Business message migration, native SDK integration and schema negotiation remain later work. ROS/DDS need their own type adapters.
Published CDR dependency update
Consume published
dimos-cdrgen==0.1.2throughout this stack, including packaging examples, the Python lock and the Nix generator wheel. PyPI release and successful publisher run. Downloaded wheel/sdist hashes match that run's artifacts exactly.The external CDR library fix is available as fork release v0.2.4-dimos.1, pinned to its tested commit. Shared SDK API 0.2.0 is isolated in #4774; explicit legacy SDK 0.1.0 pins remain compatible and are respected by autofix. No DimOS PR has been merged.
Final combined-stack verification after installing the published generator: SDK 158, adapters 2, mapper 102, MLS 135, local planner 93, follower 63, V4L2 6 tests; all 12 real native/DimSim exchanges pass. The seven Nix source-staging layouts pass locked Cargo dependency resolution using archive
8101c8db4a50043f1dbd0127fd00220ec9b5a37a. Full Nix builds and hardware/model-dependent tests remain unverified. These are combined-tip results, not independent full test runs of every intermediate PR.Final native CI passed on the exact stack tip, including SDK/consumer builds, Rust tests and all 12 native/DimSim exchanges: https://github.com/dimensionalOS/dimos/actions/runs/39851662834