Repository navigation
Conversation
3ec0126 to
cbf9c8c
Compare
cbf9c8c to
000c98b
Compare
000c98b to
8f563d0
Compare
Review reportUpdated: 2026-10-21. Direct predecessor: #4738.
What changes and why the diff is largeAdd an explicit offline recording converter for local SQLite and MCAP, plus migration/fidelity reporting. Historical decoding is confined to this command; this is separate from live transport compatibility. Review mapSuggested entry points: dimos/memory/convert_recording.py, dimos/memory/recording_migration.py, dimos/memory/cli/app.py, docs/development/convert-recordings.md. Complete file mapImplementation (3)
Tests (2)
Documentation and replay inputs (1)
Review focus and scope reductions
ValidationFresh checks on Reproduction commands, not executed here unless stated aboveRun from this PR's own checkout root after installing its documented test dependencies. These are selected review entry points, not a claim of full-stack coverage. uv run pytest dimos/memory/test_convert_recording.py dimos/memory/test_recording_migration.py
dimos mem convert OLD NEW --dry-runRemaining workInstalled-wheel converter execution and unsupported historical formats were not retested. Source/output protection and blocked pickle inputs remain intact. |
8f563d0 to
25dc750
Compare
What this adds
Add offline
dimos mem convertcommands for local MCAP and SQLite recordings. Conversion preserves timestamps and supported fields, writes a fidelity report and never overwrites the source or an existing destination.Base: #4738. The converter uses the standard MCAP writer and an explicit historical decode boundary.
How to test
Start with
dimos mem convert OLD NEW --dry-run. Follow the conversion guide for formats and expected output.All 35 local conversion tests passed again after restacking. Repository hooks passed on the cleaned stack tip. Installed-wheel tests were not rerun. Unsupported formats and pickle inputs remain blocked.
Review report: file map, scope and verification
CDR dependencies and TF conventions
The stack consumes published dimos-cdrgen 0.1.2 and the immutable CDR library fix. SDK #4774 now uses standard ROS
TFMessage,TransformStampedand integerTime, with no per-driver TF codec callbacks or parallel public transform type. The externaltransformslibrary, validated by its complete std/no_std/serde and ARM verification gate, owns the frame tree, common-time lookup, interpolation and static history. Its atomic batch patch is pinned to5ae9563de0c02638c04e393aadfad28444a4398e.Combined-stack local validation: SDK 121, macros 22, mapper 101, MLS 135, local planner 91, follower 63, V4L2 6 and depth2depth 12 Rust tests; all 24 native/DimSim/port-contract acceptance tests pass without skips. The mapper exchange includes Python CDR
tf_staticinput; the follower exchange covers drive, arrival, a new goal and empty-path stop. Missing native binaries fail the dedicated job. RealSense passescargo check --all-targets --features docs-only; device linking and hardware execution were not tested. Seven real source-staging layouts pass locked Cargo resolution. Native acceptance for tipcc463c163aed465f7c1d6808165bf640820b0182: workflow run. These are combined-tip results, with the SDK additionally tested standalone at its own layer.Native Nix inputs use verified source archive
f7723ad4d5b9aa5dfe63614b6b537d1ccc2d212e, SHA256f90af8fa794a34d53ee9481c6d0bdb63138853b30f851d92960fd34224ff62b2. Full Nix builds remain unverified. SDK static edges persist after receipt; LCM/Zenoh do not acquire DDS transient-local durability from CDR. Existing Python mount publishers retain dynamictfcompatibility. Legacy modules remain explicitly pinned to SDK 0.1.0.Stack #4776 preserves existing history and PR bases. Current main still has conflicts with the original stack; this change does not rebase onto main. No DimOS PR has been merged.