Repository navigation
Conversation
f68a148 to
996a5e3
Compare
996a5e3 to
b094101
Compare
Review reportUpdated: 2026-10-21. Direct predecessor: #4735.
What changes and why the diff is largeThis PR adds acceptance tests for generated-message capture and selected collection/robot graphs. It does not implement a new default transport or finish capture cutover. Review mapSuggested entry points: dimos/core/test_cdr_default_recording.py, dimos/imitation/collection/test_cdr_default_graph.py, dimos/robot/galaxea/r1pro/test_cdr_default_graph.py, dimos/core/test_transport_factory.py. Complete file mapTests (4)
Review focus and scope reductions
ValidationFresh rerun on Reproduction commands, not executed here unless stated aboveRun from this PR's own checkout root after installing its documented test dependencies. These are selected review entry points, not a claim of full-stack coverage. uv run pytest dimos/core/test_cdr_default_recording.py dimos/imitation/collection/test_cdr_default_graph.py dimos/robot/galaxea/r1pro/test_cdr_default_graph.py dimos/core/test_transport_factory.pyRemaining workImplement generated-message Python capture and the missing XArm/Piper collection edges, then rerun complete selected graphs. Do not merge this WIP layer with unresolved acceptance failures. |
b094101 to
75cfb7e
Compare
Add acceptance checks for default recording, collection JointState/status wiring and R1 chassis transport matching.
Base: #4735. Generated-message codec selection lives in #4722 and native SDK adaptation in #4774.
Add an unconditional PR workflow that builds/tests native SDK and consumers, prepares the pinned DimSim runtime, and runs real Python/native/TypeScript message exchanges. Missing dependencies or binaries fail this dedicated job instead of silently skipping. The final combined stack passed all 12 selected native/DimSim tests locally; cdrgen's separate compiled Python/C++/Rust acceptance workflow is in TomCC7/dimos-cdrgen#1. GitHub branch-protection settings have not been changed.
This PR remains WIP for existing default-cutover failures. An earlier acceptance run had 37 passes and four failures: Python TransportRecorder skips generated messages on LCM and Zenoh, and XArm/Piper collection recorders lack the expected generated aggregate JointState input. These features were not changed or revalidated by the codec repair. Resolve them before merging this layer; passing native interoperability does not establish whole-graph acceptance.
Existing boundary review: #4739 (comment)
CDR dependencies and TF conventions
The stack consumes published dimos-cdrgen 0.1.2 and the immutable CDR library fix. SDK #4774 now uses standard ROS
TFMessage,TransformStampedand integerTime, with no per-driver TF codec callbacks or parallel public transform type. The externaltransformslibrary, validated by its complete std/no_std/serde and ARM verification gate, owns the frame tree, common-time lookup, interpolation and static history. Its atomic batch patch is pinned to5ae9563de0c02638c04e393aadfad28444a4398e.Combined-stack local validation: SDK 121, macros 22, mapper 101, MLS 135, local planner 91, follower 63, V4L2 6 and depth2depth 12 Rust tests; all 24 native/DimSim/port-contract acceptance tests pass without skips. The mapper exchange includes Python CDR
tf_staticinput; the follower exchange covers drive, arrival, a new goal and empty-path stop. Missing native binaries fail the dedicated job. RealSense passescargo check --all-targets --features docs-only; device linking and hardware execution were not tested. Seven real source-staging layouts pass locked Cargo resolution. Native acceptance for tipcc463c163aed465f7c1d6808165bf640820b0182: workflow run. These are combined-tip results, with the SDK additionally tested standalone at its own layer.Native Nix inputs use verified source archive
f7723ad4d5b9aa5dfe63614b6b537d1ccc2d212e, SHA256f90af8fa794a34d53ee9481c6d0bdb63138853b30f851d92960fd34224ff62b2. Full Nix builds remain unverified. SDK static edges persist after receipt; LCM/Zenoh do not acquire DDS transient-local durability from CDR. Existing Python mount publishers retain dynamictfcompatibility. Legacy modules remain explicitly pinned to SDK 0.1.0.Stack #4776 preserves existing history and PR bases. Current main still has conflicts with the original stack; this change does not rebase onto main. No DimOS PR has been merged.