Repository navigation
Conversation
74ec597 to
26a38b5
Compare
26a38b5 to
d7affe2
Compare
d7affe2 to
77fa4af
Compare
Review reportUpdated: 2026-10-21. Direct predecessor: #4737.
What changes and why the diff is largeMigrate coordinator/task/teleoperation wire ports to generated messages, keeping existing numerical control and IK values behind explicit adapters. Hosted, keyboard and WebXR producers are updated with their consumers; WebXR adds schema-based browser CDR command encoding. Review mapSuggested entry points: dimos/control/coordinator.py, dimos/control/tasks/pose_target_ik.py, dimos/teleop/hosted/arm_command.py, dimos/teleop/webxr/module.py, dimos/teleop/webxr/web/static/command_codec.mjs. Complete file mapImplementation (20)
Build and dependency metadata (2)
Tests (13)
Documentation and replay inputs (1)
Review focus and scope reductions
ValidationFresh checks on Reproduction commands, not executed here unless stated aboveRun from this PR's own checkout root after installing its documented test dependencies. These are selected review entry points, not a claim of full-stack coverage. uv run pytest dimos/control/test_coordinator_routing.py dimos/control/test_joint_commands.py dimos/control/test_per_robot_joint_states.py
uv run pytest dimos/teleop/hosted/test_arm_command.py dimos/teleop/hosted/test_go2_command.py dimos/teleop/keyboard/test_keyboard_teleop_module.py dimos/teleop/webxr/test_module.py dimos/teleop/webxr/test_blueprints.pyRemaining workInternal legacy value adapters remain because their consumers still use those models. Standalone installed-layer, physical browser/headset and hardware behavior are unverified. Full stack type/graph migration remains WIP. |
77fa4af to
0a72a63
Compare
What this adds
Migrate control, manipulation and teleop ports to generated CDR messages. Keep task behavior and driver conversions, and update WebXR, keyboard and hosted command paths.
Base: #4737. Existing transport specs and coordinator backend selection replace the old
CdrTransportcalls.Validation and limits
Fresh cleanup checks: 239 control and teleop tests passed, including JavaScript encoder/Python interoperability and both backend payload cases. The single-process LCM test uses memq and closes its owned transports. Repository hooks passed.
WIP: standalone installed-layer, physical browser/headset and hardware behavior are unverified. Drivers were mocked; multicast networking was not certified.
Review report: file map, scope and verification
CDR dependencies and TF conventions
The stack consumes published dimos-cdrgen 0.1.2 and the immutable CDR library fix. SDK #4774 now uses standard ROS
TFMessage,TransformStampedand integerTime, with no per-driver TF codec callbacks or parallel public transform type. The externaltransformslibrary, validated by its complete std/no_std/serde and ARM verification gate, owns the frame tree, common-time lookup, interpolation and static history. Its atomic batch patch is pinned to5ae9563de0c02638c04e393aadfad28444a4398e.Combined-stack local validation: SDK 121, macros 22, mapper 101, MLS 135, local planner 91, follower 63, V4L2 6 and depth2depth 12 Rust tests; all 24 native/DimSim/port-contract acceptance tests pass without skips. The mapper exchange includes Python CDR
tf_staticinput; the follower exchange covers drive, arrival, a new goal and empty-path stop. Missing native binaries fail the dedicated job. RealSense passescargo check --all-targets --features docs-only; device linking and hardware execution were not tested. Seven real source-staging layouts pass locked Cargo resolution. Native acceptance for tipcc463c163aed465f7c1d6808165bf640820b0182: workflow run. These are combined-tip results, with the SDK additionally tested standalone at its own layer.Native Nix inputs use verified source archive
f7723ad4d5b9aa5dfe63614b6b537d1ccc2d212e, SHA256f90af8fa794a34d53ee9481c6d0bdb63138853b30f851d92960fd34224ff62b2. Full Nix builds remain unverified. SDK static edges persist after receipt; LCM/Zenoh do not acquire DDS transient-local durability from CDR. Existing Python mount publishers retain dynamictfcompatibility. Legacy modules remain explicitly pinned to SDK 0.1.0.Stack #4776 preserves existing history and PR bases. Current main still has conflicts with the original stack; this change does not rebase onto main. No DimOS PR has been merged.