Repository navigation
Conversation
There was a problem hiding this comment.
go2 replay realtime (arm64)
Details
| Benchmark suite | Current: 12c81e0 | Previous: ecc2b8f | Ratio |
|---|---|---|---|
peak memory |
1588.184 MB |
1570.996 MB |
1.01 |
peak threads |
347 threads |
355 threads |
0.98 |
network (transport) |
2724.766 MB |
2730.387 MB |
1.00 |
disk write |
1.742 MB |
1.496 MB |
1.16 |
instructions |
115.685 G |
115 G |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
59b492b to
3ce7f4e
Compare
TomCC7
left a comment
There was a problem hiding this comment.
need to think about an example used in this pr
There was a problem hiding this comment.
verify that we do need this and can't be solved by rust's own cdr lib
[Medium impact] The PR extends the recording and replay workflow for generated CDR messages. The confirmed optional-metadata readback limitation is non-blocking. The mixed-file readback assessment depends on PR #4733 landing. Findings
SummaryAdds native CDR recording to SQLite and MCAP, plus Python readback through
Reviews (1) · Last reviewed commit: "Merge branch 'cc/feat/cdr-shared-codec' ..." · Reviewed by Greptile |
| if summary is not None and summary.statistics is not None: | ||
| for cid, ch in summary.channels.items(): |
There was a problem hiding this comment.
CdrMcapStore silently reports no streams when a valid MCAP file omits statistics or its summary. With Writer(use_statistics=False), a recording containing three directly readable CDR messages opens successfully but exposes no streams or observations. This is a non-blocking readback limitation for recordings that omit this optional metadata. Scan the messages in this case, or raise a clear unsupported-file error instead of presenting the recording as empty.
Artifacts
Executed reproduction script for recordings with optional metadata omitted
- The complete authored and executed Python source writes three MCAP variants and compares direct reader availability with store readback, isolating the optional-metadata failure.
Readback log with statistics enabled
- Executed the statistics-enabled control and captured its command, working directory, exit code, installed source quotes, and three decoded store observations, showing normal readback works.
Readback log with statistics or summary absent
- Executed both missing-metadata cases and captured three directly readable messages versus zero store streams in each case, confirming valid recordings silently appear empty.
16906b4 to
fb2d4e8
Compare
fb2d4e8 to
12c81e0
Compare
What this adds
ros2msgschemas in MCAP and mark channels ascdr.CdrMcapStore.Base: #4774 (shared native SDK), after #4722. Recording uses reception time; the original
header.stampstays in the payload.How to test
From this PR's checkout, with Linux,
uv, Rust and the native build dependencies:Wait for recorder readiness, record for about 15 seconds, then press Ctrl+C once. Open the saved
artifact_pathin Foxglove and viewposein framemap. It should move in a circle. No robot, ROS installation or API key is needed.Prerequisites, expected output and Python readback.
WIP: local installation, recording and Python readback were checked. Foxglove UI rendering and Nix were not verified. Business blueprint migration, compression and default cutover remain later work.