Repository navigation
Conversation
There was a problem hiding this comment.
go2 replay realtime (arm64)
Details
| Benchmark suite | Current: 086c166 | Previous: ecc2b8f | Ratio |
|---|---|---|---|
peak memory |
1591.996 MB |
1570.996 MB |
1.01 |
peak threads |
353 threads |
355 threads |
0.99 |
network (transport) |
2722.111 MB |
2730.387 MB |
1.00 |
disk write |
1.52 MB |
1.496 MB |
1.02 |
instructions |
115.235 G |
115 G |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cc/feat/cdr-message-packages #4721 +/- ##
================================================================
- Coverage 82.33% 82.33% -0.01%
================================================================
Files 1677 1678 +1
Lines 156940 157004 +64
Branches 13161 13166 +5
================================================================
+ Hits 129220 129266 +46
- Misses 24048 24075 +27
+ Partials 3672 3663 -9
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 16 files with indirect coverage changes 🚀 New features to boost your workflow:
|
[Medium impact] No merge-blocking issue was identified. The installed external message flow passed provider registration, CDR roundtrip, and built-in type identity checks. SummaryAdds a standalone external message project that reuses the built-in
TomCC7 explicitly documents that these examples require the matching review DimOS wheel; that requirement is intentional. No actionable issues were found. No merge-blocking issue was identified in the reviewed changes. Reviews (1) · Last reviewed commit: "Merge branch 'cc/review/cdr-preserve-leg..." · Reviewed by Greptile |
5032b12 to
085d09d
Compare
0446dd3 to
67c50a0
Compare
67c50a0 to
086c166
Compare
What this adds
Install an external
.msgproject as a Python package. Its cdrgen provider registers the generated types alongside built-in messages.Base: #4366. This layer adds external message authoring and registration; it does not add another code generator or transport SDK.
How to test
From this PR's checkout, with
uvand a C++ compiler:No previous PR installation is needed. The example checks provider registration, shared Header identity and decoded DeviceReading values. Reinstall the external package and restart Python after changing definitions.
Full instructions. WIP: application integration follows in later layers.
Shared CDR foundation
Standard ROS definitions are fetched and verified through the existing source lock and generation pipeline in #4366. Native SDK support is included in #4722. Shared Python value implementations and regressions are reviewed in #4800–#4803 before the #4734 caller migration. SDK and consumers use the same generated Rust message crate, including
Time,TransformStampedandTFMessage; there is no separate TF schema package or generation command. Camera/depth callers migrate in #4734 and mapping/navigation callers in #4737.The external CDR and transforms library pins remain unchanged. Local verification passed 122 SDK tests, all existing native consumer suites, and all 24 real native/DimSim/port acceptance tests without skips. Seven staged Nix source layouts resolve exactly one message crate with locked Cargo metadata. This is not a full Nix build or hardware validation. Fresh CI runs verify #4722 independently and the combined stack tip.
Stack #4804 contains the 12 original feature PRs and four separately reviewed adapter/buffer PRs (#4800–#4803). The redundant #4774 is superseded by #4722. No feature PR has been merged into main; existing conflicts with main and the WIP cutover failures in #4739 remain.