Repository navigation
Conversation
67a7b69 to
55bd6bc
Compare
55bd6bc to
6ebdb3c
Compare
6ebdb3c to
7c6eb9d
Compare
Review reportUpdated: 2026-10-21. Direct predecessor: #4739.
What changes and why the diff is largeAdd a static legacy-boundary scanner and an explicit WIP status document. No legacy code is deleted by this PR. Review mapSuggested entry points: scripts/audit_cdr_boundaries.py, docs/development/cdr-cutover-status.md. Complete file mapImplementation (1)
Documentation and replay inputs (1)
Review focus and scope reductions
ValidationFresh audit at Reproduction commands, not executed here unless stated aboveRun from this PR's own checkout root after installing its documented test dependencies. These are selected review entry points, not a claim of full-stack coverage. python scripts/audit_cdr_boundaries.py --output /tmp/cdr-boundaries.json
python scripts/audit_cdr_boundaries.py --checkRemaining workThe four documented #4739 blockers and remaining business graphs prevent cleanup. Static candidate counts must not be presented as 312 confirmed runtime failures. Actual legacy removal is still absent. |
7c6eb9d to
71c0889
Compare
What this adds
WIP audit of remaining legacy message imports and typed ports before deleting old APIs.
Base: #4739. No legacy implementation is removed here.
How to check
The audit reports 312 legacy port declarations and 998 imports. These are static candidates, not confirmed runtime failures.
--checkreturns nonzero while candidates remain.Repository hooks passed. Cleanup remains blocked on the four failures in #4739 and remaining graph migrations. Current status.
Review report: file map, scope and verification
Published CDR dependency update
Consume published
dimos-cdrgen==0.1.2throughout this stack, including packaging examples, the Python lock and the Nix generator wheel. PyPI release and successful publisher run. Downloaded wheel/sdist hashes match that run's artifacts exactly.The external CDR library fix is available as fork release v0.2.4-dimos.1, pinned to its tested commit. Shared SDK API 0.2.0 is isolated in #4774; explicit legacy SDK 0.1.0 pins remain compatible and are respected by autofix. No DimOS PR has been merged.
Final combined-stack verification after installing the published generator: SDK 158, adapters 2, mapper 102, MLS 135, local planner 93, follower 63, V4L2 6 tests; all 12 real native/DimSim exchanges pass. The seven Nix source-staging layouts pass locked Cargo dependency resolution using archive
8101c8db4a50043f1dbd0127fd00220ec9b5a37a. Full Nix builds and hardware/model-dependent tests remain unverified. These are combined-tip results, not independent full test runs of every intermediate PR.Current main has additional mapping/control changes that conflict with this stack. The dependency release update preserves the existing stack base; a main rebase is still required before merging. Final native acceptance passed on the stack tip: https://github.com/dimensionalOS/dimos/actions/runs/39851662834
Final native CI passed on the exact stack tip, including SDK/consumer builds, Rust tests and all 12 native/DimSim exchanges: https://github.com/dimensionalOS/dimos/actions/runs/39851662834