Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collection's episode monitor and recorder now agree with WebXR/coordinator generated CDR ports: UInt32 buttons, String status, Image and JointState. The existing EpisodeStatus JSON document and state machine stay intact; the document's timestamp still defines episode boundaries. DataPrep projects canonical image row layout and named joint vectors, retaining sparse-command reconstruction and existing dataset selection behavior.
Project: https://linear.app/dimensional/project/message-encoding-refactor-05a3ddb4af3e/overview
Parent: #4716 (
a9b0d06211aae2d47e7b140834e6eccc8ef0cd61). This is one verified graph in an incomplete proposal. Isolated LeRobot host/worker ports, other remaining graphs, final dependency retirement and stack organization follow.File change summary
MCAP dataset fixtures now contain complete ros2msg schemas with plain CDR values and standard NONE/ZSTD chunk compression. DataPrep no longer imports historical Python message classes from recording metadata to load LCM codecs. Historical typed LCM/JPEG-in-LCM MCAP inputs fail with an explicit conversion instruction. Unrelated generic object/telemetry formats are outside this change.
Verification
python -Iand site-packages assertions.nixis absent.af1f4a11f6e31d16db5f1533854f43593d059e7ae6c78f343f0e2717ae781fcb.Manual offline test
With the development and learning test dependencies installed:
DIMOS_TRANSPORT=lcm LCM_DEFAULT_URL=memq:// uv run pytest -o addopts='' --import-mode=importlib -q \ dimos/imitation/collection dimos/imitation/dataprep \ dimos/imitation/test_datacollection_e2e.pyNo checkpoint/model, inference, training, camera, robot or external provider was used. This verifies the dataset format writer, not a full LeRobot policy runtime. No CI conclusion or human acceptance is claimed; CI polling and benchmark investigation remain paused.