Skip to content

Add more description to AUTO_RANDOM - #21863

Merged
ti-chi-bot[bot] merged 4 commits into
pingcap:masterfrom
djshow832:auto_random
Aug 12, 2026
Merged

Add more description to AUTO_RANDOM#21863
ti-chi-bot[bot] merged 4 commits into
pingcap:masterfrom
djshow832:auto_random

Conversation

@djshow832

@djshow832 djshow832 commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

What is changed, added or deleted? (Required)

close pingcap/docs#23404

Add 2 more descriptions:

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Summary by CodeRabbit

文档

  • 更新 AUTO_RANDOM 位结构说明,明确符号位取决于 UNSIGNED 属性。
  • 说明隐式分配值始终为正数,且有符号列的符号位固定为 0
  • 补充自增位长度至少为 27 位的约束,并保留原有保留位说明。

@djshow832
djshow832 requested a review from tangenta August 3, 2026 09:26
@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 3, 2026
@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 8315eddb-1151-4cda-85ed-88e5587dacc4

📥 Commits

Reviewing files that changed from the base of the PR and between bf334ea and 1aa0dc7.

📒 Files selected for processing (1)
  • auto-random.md

📝 Walkthrough

Walkthrough

更新 AUTO_RANDOM 位结构文档,补充隐式分配值的符号位规则,并新增自增位至少为 27 位的约束。

Changes

AUTO_RANDOM 文档更新

Layer / File(s) Summary
更新 AUTO_RANDOM 位结构规则
auto-random.md
明确隐式分配值始终为正数。有符号列的符号位固定为 0,无符号列没有符号位。显式插入值不适用该规则。自增位至少为 27 位。

Estimated code review effort: 1 (简单) | ~5 分钟

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning [#23404] 已补充自增位至少 27 位和默认正值说明,但未明确“必须大于 27”及指定负基数时的例外。 请按 issue #23404 明确 R-S 必须大于 27,并说明有符号类型仅在未指定负基数时默认生成正值。
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed 标题准确概括了对 AUTO_RANDOM 文档增加说明的主要变更,简洁且与改动相关。
Description check ✅ Passed 描述已填写变更内容、适用版本和关联 issue,并保留模板要求的主要章节;可选检查项未勾选不影响完整性。
Out of Scope Changes check ✅ Passed 所有变更均限于 AUTO_RANDOM 文档说明,未发现与关联 issue 无关的代码或文件改动。
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 3, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2


ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 0dac995c-956f-4ba0-a647-16b4b036b572

📥 Commits

Reviewing files that changed from the base of the PR and between 481f977 and 73985a8.

📒 Files selected for processing (1)
  • auto-random.md

Comment thread auto-random.md Outdated
Comment thread auto-random.md Outdated
djshow832 and others added 2 commits August 3, 2026 20:59
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 0fa77d83-3d1f-4d1e-9868-8865975e6ea1

📥 Commits

Reviewing files that changed from the base of the PR and between 73985a8 and bf334ea.

📒 Files selected for processing (1)
  • auto-random.md

Comment thread auto-random.md Outdated
@qiancai qiancai added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 5, 2026
Comment thread auto-random.md Outdated

@qiancai qiancai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 11, 2026
@ti-chi-bot

ti-chi-bot Bot commented Aug 11, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-08-03 09:28:29.083678231 +0000 UTC m=+2433895.119773287: ☑️ agreed by tangenta.
  • 2026-08-11 09:38:24.379762357 +0000 UTC m=+3125690.415857403: ☑️ agreed by qiancai.

Co-authored-by: Grace Cai <qqzczy@126.com>
@qiancai qiancai self-assigned this Aug 12, 2026
@qiancai qiancai added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Aug 12, 2026
github-actions Bot added a commit to qiancai/docs that referenced this pull request Aug 12, 2026
Synced from: pingcap/docs-cn#21863
Target PR: pingcap#23498

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@qiancai

qiancai commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

/approve

@ti-chi-bot

ti-chi-bot Bot commented Aug 12, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Aug 12, 2026
@ti-chi-bot
ti-chi-bot Bot merged commit 26f202b into pingcap:master Aug 12, 2026
11 checks passed
@ti-chi-bot

Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #21875.

@ti-chi-bot

Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #21876.

@ti-chi-bot

Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #21877.

@ti-chi-bot

Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #21878.

@ti-chi-bot

Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #21879.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. lgtm missing-translation-status This PR does not have translation status info. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enhance the claim of auto random type limitation

4 participants