docs: fix tidb_server_memory_limit unit description (release-8.5) - #23660
docs: fix tidb_server_memory_limit unit description (release-8.5)#23660vjymisal0 wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @vjymisal0. Thanks for your PR. I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Welcome @vjymisal0! |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe documentation updates two TiDB system variable descriptions. Both descriptions list binary and decimal memory units and add a ChangesMemory unit documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This localized documentation update clarifies supported memory-limit units and adds an example; no actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Description checkExplanation The description explains the documentation change, its purpose, affected version, and related backport context. The required sections are sufficiently complete; optional checklist sections are omitted. Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Backport of the master fix (pingcap#23587) to release-8.5: clarify that both 'KiB|MiB|GiB|TiB' and 'KB|MB|GB|TB' unit formats are supported, and add a 90GiB example.
b0c8c16 to
22aa963
Compare
What is changed, added or deleted? (Required)
tidb_server_memory_limitunit description insystem-variables.mdon therelease-8.5branch, matching the wording already fixed onmaster(docs: add memory unit example for tidb_server_memory_limit #23587) and backported torelease-7.5(docs: fix tidb_server_memory_limit unit description #23588).KiB|MiB|GiB|TiBandKB|MB|GB|TBunit formats are supported, and add a90GiBexample.This gap exists on
release-7.6throughrelease-8.4as well; happy to open matching PRs for those branches if useful, or this could go through theneeds-cherry-pick-release-*bot flow instead.Which TiDB version(s) do your changes apply to? (Required)
Summary by CodeRabbit