Skip to content

port pstack post-0.15.25 (#637, #700, #702, #704, #705) - #5

Merged
caelaxie merged 1 commit into
mainfrom
cursor/port-pstack-post-0.15.25-1705
Oct 18, 2026
Merged

caelaxie merged 1 commit into
mainfrom
cursor/port-pstack-post-0.15.25-1705

Conversation

@caelaxie

@caelaxie caelaxie commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

Port upstream pstack changes after 99743e9c (#634). Version stays 0.15.25. cursor-team-kit stays 1.2.0. The short port README is unchanged.

Upstream commits

  • 182f2ce4 / #637 — add docs/harness/claude-code.md
  • 0317eb8b / #700 — brand via a type guard in typescript-best-practices (SKILL.md, references/patterns.md)
  • a9681593 / #702 — name: matches the folder for poteto-mode and make-bot-ui
  • 1b800800 / #705 — Claude Code harness doc fixes in docs/harness/claude-code.md
  • 019a6a20 / #704 — refresh docs/guide/*.md

README-only lines from #637, #704, and #705 are not applied. docs/guide/01-setup.md had no applicable line: its only upstream edit retargets the Cursor custom-mode link, which this port already replaced.

Grok adaptations kept

  • typescript-best-practices still has no paths or disable-model-invocation
  • existing spawn and skill wording in the guide (worktree isolation, .grok paths, bundled deslop, no custom mode)
  • make-bot-ui body stays the Grok Build wake-URL version; only name: changed
  • no .cursor-plugin/plugin.json

Harness proof

grok 1.0.62, on cursor/port-pstack-post-0.15.25-1705 at 4706899.

$ grok plugin validate /workspace
Plugin manifest is valid.
  name: pstack
  version: 0.15.25
  description: if you want to go fast, go deep first. pstack helps you write less, but higher quality code. rigorous agent workflows you can parallelize with confidence.
  components: 1 skill dir(s), 0 command dir(s), 1 agent dir(s)

$ grok plugin install https://github.com/pstack-ports/grok-pstack@cursor/port-pstack-post-0.15.25-1705 --trust
Installed 1 plugin(s) from https://github.com/pstack-ports/grok-pstack@cursor/port-pstack-post-0.15.25-1705: pstack

$ grok plugin list
  grok-pstack-619a4a2c: pstack [git: https://github.com/pstack-ports/grok-pstack]

$ grok plugin list --json
[
  {
    "status": "installed",
    "name": "pstack",
    "repo_key": "grok-pstack-619a4a2c",
    "version": "0.15.25",
    "path": "/home/ubuntu/.grok/installed-plugins/grok-pstack-619a4a2c",
    "source": "https://github.com/pstack-ports/grok-pstack",
    "marketplace": null
  }
]

$ grok plugin details pstack
grok-pstack-619a4a2c
  path: /home/ubuntu/.grok/installed-plugins/grok-pstack-619a4a2c
  kind: git: https://github.com/pstack-ports/grok-pstack
  installed: 2026-10-18T01:29:14.569921238+00:00
  updated: 2026-10-18T01:29:14.569921238+00:00
  plugins (1):
    pstack v0.15.25
  description: if you want to go fast, go deep first. pstack helps you write less, but higher quality code. rigorous agent workflows you can parallelize with confidence.
  components: 1 skill dir(s), 0 command dir(s), 1 agent dir(s)

$ git -C ~/.grok/installed-plugins/grok-pstack-619a4a2c rev-parse HEAD
4706899eff4603c8e1f82e6cd146a574dd54c1ac

$ grok inspect --json | jq -r '.skills[] | select(.name=="typescript-best-practices" or .name=="poteto-mode" or .name=="make-bot-ui") | "\(.name)\tplugin=\(.source.plugin_name)\tuserInvocable=\(.userInvocable)\t\(.description)"'
make-bot-ui	plugin=pstack	userInvocable=true	Use when building a custom UI (page, dashboard, buttons) that should wake a Grok Bot over a webhook, when the user must provide a webhook sender key, or when exposing that UI on Tailscale.
poteto-mode	plugin=pstack	userInvocable=true	poteto's agent style for concise, detailed responses, deliberate subagents, unslopped prose, simple code, and verified work. Use for poteto, /poteto-mode, or requests to work in this style.
typescript-best-practices	plugin=pstack	userInvocable=true	TypeScript best practices. Use when reading or editing any .ts or .tsx file.

grok inspect loads 57 skills from plugin pstack. typescript-best-practices, poteto-mode, and make-bot-ui all load under those folder names.

A model turn did not run. grok -p '/poteto-mode say ok' --max-turns 1 exited 1: not signed in, and XAI_API_KEY is unset.

Open in Web Open in Cursor 

Bring in the pstack-path changes after 99743e9c. Version stays 0.15.25
and cursor-team-kit stays 1.2.0. The short README stays.

Co-authored-by: Kaitian Xie <caelaxie@users.noreply.github.com>

@caelaxie caelaxie left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes requested (comment review; same-account author blocks request_changes).

bar

  1. minimum changes — looks ok at a glance: guide refresh, brand type-guard, name: folder match, docs/harness/claude-code.md; grok adaptations kept as stated; README-only upstream lines correctly skipped.
  2. parity/versions — README still 0.15.25 / cursor-team-kit 1.2.0; brand line and claude-code harness match upstream path content.
  3. harness proof — missing. no install/list output, no exercise of changed skills (typescript-best-practices, poteto-mode, make-bot-ui). need real:
    • grok plugin install https://github.com/pstack-ports/grok-pstack --trust (from this head)
    • grok plugin list showing it loaded
    • short proof the changed skills resolve/run
  4. issue linkage — n/a (no open tracking issue).

paste harness proof in the pr (comment or body), push if needed. re-review only on new commits.

|------|---------|
| Discriminated unions | Model variants with a `kind` literal discriminant so impossible states can't be represented. No optional-field bags. |
| Branded types | Brand primitives with `& { readonly __brand: "X" }` so they can't be mixed up. Validate once at the boundary. |
| Branded types | Brand primitives with `& { readonly __brand: "X" }` so they can't be mixed up. Validate once at the boundary. A brand comes from a verifying type guard (`input is AgentId`), never from `as`. |

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

content ok vs upstream brand-via-type-guard. blocker is still pr-level: paste grok plugin install … --trust + grok plugin list from this head, and exercise this skill plus poteto-mode / make-bot-ui.

@cursor

cursor Bot commented Oct 18, 2026

Copy link
Copy Markdown

Harness proof, grok 1.0.62, on cursor/port-pstack-post-0.15.25-1705 at 4706899.

$ grok plugin validate /workspace
Plugin manifest is valid.
  name: pstack
  version: 0.15.25
  description: if you want to go fast, go deep first. pstack helps you write less, but higher quality code. rigorous agent workflows you can parallelize with confidence.
  components: 1 skill dir(s), 0 command dir(s), 1 agent dir(s)

$ grok plugin install https://github.com/pstack-ports/grok-pstack@cursor/port-pstack-post-0.15.25-1705 --trust
Installed 1 plugin(s) from https://github.com/pstack-ports/grok-pstack@cursor/port-pstack-post-0.15.25-1705: pstack

$ grok plugin list
  grok-pstack-619a4a2c: pstack [git: https://github.com/pstack-ports/grok-pstack]

$ grok plugin list --json
[
  {
    "status": "installed",
    "name": "pstack",
    "repo_key": "grok-pstack-619a4a2c",
    "version": "0.15.25",
    "path": "/home/ubuntu/.grok/installed-plugins/grok-pstack-619a4a2c",
    "source": "https://github.com/pstack-ports/grok-pstack",
    "marketplace": null
  }
]

$ grok plugin details pstack
grok-pstack-619a4a2c
  path: /home/ubuntu/.grok/installed-plugins/grok-pstack-619a4a2c
  kind: git: https://github.com/pstack-ports/grok-pstack
  installed: 2026-10-18T01:29:14.569921238+00:00
  updated: 2026-10-18T01:29:14.569921238+00:00
  plugins (1):
    pstack v0.15.25
  description: if you want to go fast, go deep first. pstack helps you write less, but higher quality code. rigorous agent workflows you can parallelize with confidence.
  components: 1 skill dir(s), 0 command dir(s), 1 agent dir(s)

$ git -C ~/.grok/installed-plugins/grok-pstack-619a4a2c rev-parse HEAD
4706899eff4603c8e1f82e6cd146a574dd54c1ac

$ grok inspect --json | jq -r '.skills[] | select(.name=="typescript-best-practices" or .name=="poteto-mode" or .name=="make-bot-ui") | "\(.name)\tplugin=\(.source.plugin_name)\tuserInvocable=\(.userInvocable)\t\(.description)"'
make-bot-ui	plugin=pstack	userInvocable=true	Use when building a custom UI (page, dashboard, buttons) that should wake a Grok Bot over a webhook, when the user must provide a webhook sender key, or when exposing that UI on Tailscale.
poteto-mode	plugin=pstack	userInvocable=true	poteto's agent style for concise, detailed responses, deliberate subagents, unslopped prose, simple code, and verified work. Use for poteto, /poteto-mode, or requests to work in this style.
typescript-best-practices	plugin=pstack	userInvocable=true	TypeScript best practices. Use when reading or editing any .ts or .tsx file.

$ grok -p '/poteto-mode say ok' --max-turns 1
Not signed in. To authenticate without a browser, run:
  grok login --device-code

Alternatively, set the XAI_API_KEY environment variable or run `grok login` on a machine with a browser.
Error: Not signed in. To authenticate without a browser, run:
  grok login --device-code

Alternatively, set the XAI_API_KEY environment variable or run `grok login` on a machine with a browser.

grok inspect loads 57 skills from plugin pstack. typescript-best-practices, poteto-mode, and make-bot-ui load under those folder names. A model turn did not run: not signed in, and XAI_API_KEY is unset.

@caelaxie caelaxie left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved (posted as COMMENT: same-author PR, GitHub rejects APPROVE).

re-review at 4706899:

  1. minimum changes: every hunk diffed against upstream cursor/plugins 99743e9c...019a6a20, pstack/ only.
    • guide 02-09, docs/harness/claude-code.md (new, 67 lines), typescript-best-practices SKILL.md + references/patterns.md: byte-identical to upstream.
    • name: Make Bot UI -> make-bot-ui, name: Poteto Mode -> poteto-mode: upstream #702 (a9681593), identical. not a grok divergence.
    • 10-recipes-and-pitfalls.md: upstream reword applied. it keeps the port's existing isolation: "worktree" tail in place of upstream's cloud-agents wording. that's a prior grok spawn adaptation, and the body lists it.
    • skipped: pstack/README.md (the port README is short, same as the earlier ports) and the 01-setup.md custom-mode link (the port already replaced that line). both are correct skips.
    • claude-code.md: no prior port policy drops upstream pstack/docs files. the port mirrors pstack/ minus Cursor manifests, so shipping the upstream file unchanged is consistent. grok never loads it.
  2. parity: all 5 upstream pstack commits in the range are ported. nothing dropped. no version bump upstream in this range, so 0.15.25 matches the manifest, README, and grok plugin list.
  3. harness: install --trust + list + details, with installed rev-parse = 4706899 (head unchanged). grok inspect loads typescript-best-practices / poteto-mode / make-bot-ui under folder names from plugin=pstack. that's enough for frontmatter/doc changes, since a live turn is blocked only by auth. CI Validate plugin is green.
  4. linkage: no open issues relate. none needed.

squash-merging.

@caelaxie
caelaxie merged commit 33329f8 into main Oct 18, 2026
1 check passed
@caelaxie
caelaxie deleted the cursor/port-pstack-post-0.15.25-1705 branch October 18, 2026 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants