Repository navigation
port pstack post-0.15.25 (#637, #700, #702, #704, #705) - #5
Conversation
Bring in the pstack-path changes after 99743e9c. Version stays 0.15.25 and cursor-team-kit stays 1.2.0. The short README stays. Co-authored-by: Kaitian Xie <caelaxie@users.noreply.github.com>
caelaxie
left a comment
There was a problem hiding this comment.
changes requested (comment review; same-account author blocks request_changes).
bar
- minimum changes — looks ok at a glance: guide refresh, brand type-guard,
name:folder match,docs/harness/claude-code.md; grok adaptations kept as stated; README-only upstream lines correctly skipped. - parity/versions — README still
0.15.25/ cursor-team-kit1.2.0; brand line and claude-code harness match upstream path content. - harness proof — missing. no install/list output, no exercise of changed skills (
typescript-best-practices,poteto-mode,make-bot-ui). need real:grok plugin install https://github.com/pstack-ports/grok-pstack --trust(from this head)grok plugin listshowing it loaded- short proof the changed skills resolve/run
- issue linkage — n/a (no open tracking issue).
paste harness proof in the pr (comment or body), push if needed. re-review only on new commits.
| |------|---------| | ||
| | Discriminated unions | Model variants with a `kind` literal discriminant so impossible states can't be represented. No optional-field bags. | | ||
| | Branded types | Brand primitives with `& { readonly __brand: "X" }` so they can't be mixed up. Validate once at the boundary. | | ||
| | Branded types | Brand primitives with `& { readonly __brand: "X" }` so they can't be mixed up. Validate once at the boundary. A brand comes from a verifying type guard (`input is AgentId`), never from `as`. | |
There was a problem hiding this comment.
content ok vs upstream brand-via-type-guard. blocker is still pr-level: paste grok plugin install … --trust + grok plugin list from this head, and exercise this skill plus poteto-mode / make-bot-ui.
|
Harness proof, grok 1.0.62, on
|
caelaxie
left a comment
There was a problem hiding this comment.
approved (posted as COMMENT: same-author PR, GitHub rejects APPROVE).
re-review at 4706899:
- minimum changes: every hunk diffed against upstream
cursor/plugins99743e9c...019a6a20,pstack/only.- guide 02-09,
docs/harness/claude-code.md(new, 67 lines),typescript-best-practicesSKILL.md+references/patterns.md: byte-identical to upstream. name: Make Bot UI->make-bot-ui,name: Poteto Mode->poteto-mode: upstream #702 (a9681593), identical. not a grok divergence.10-recipes-and-pitfalls.md: upstream reword applied. it keeps the port's existingisolation: "worktree"tail in place of upstream's cloud-agents wording. that's a prior grok spawn adaptation, and the body lists it.- skipped:
pstack/README.md(the port README is short, same as the earlier ports) and the01-setup.mdcustom-mode link (the port already replaced that line). both are correct skips. claude-code.md: no prior port policy drops upstreampstack/docsfiles. the port mirrorspstack/minus Cursor manifests, so shipping the upstream file unchanged is consistent. grok never loads it.
- guide 02-09,
- parity: all 5 upstream pstack commits in the range are ported. nothing dropped. no version bump upstream in this range, so 0.15.25 matches the manifest, README, and
grok plugin list. - harness: install --trust + list + details, with installed rev-parse =
4706899(head unchanged).grok inspectloads typescript-best-practices / poteto-mode / make-bot-ui under folder names from plugin=pstack. that's enough for frontmatter/doc changes, since a live turn is blocked only by auth. CIValidate pluginis green. - linkage: no open issues relate. none needed.
squash-merging.
Port upstream pstack changes after
99743e9c(#634). Version stays 0.15.25. cursor-team-kit stays 1.2.0. The short port README is unchanged.Upstream commits
182f2ce4/ #637 — adddocs/harness/claude-code.md0317eb8b/ #700 — brand via a type guard intypescript-best-practices(SKILL.md,references/patterns.md)a9681593/ #702 —name:matches the folder forpoteto-modeandmake-bot-ui1b800800/ #705 — Claude Code harness doc fixes indocs/harness/claude-code.md019a6a20/ #704 — refreshdocs/guide/*.mdREADME-only lines from #637, #704, and #705 are not applied.
docs/guide/01-setup.mdhad no applicable line: its only upstream edit retargets the Cursor custom-mode link, which this port already replaced.Grok adaptations kept
typescript-best-practicesstill has nopathsordisable-model-invocation.grokpaths, bundleddeslop, no custom mode)make-bot-uibody stays the Grok Build wake-URL version; onlyname:changed.cursor-plugin/plugin.jsonHarness proof
grok 1.0.62, on
cursor/port-pstack-post-0.15.25-1705at4706899.grok inspectloads 57 skills from plugin pstack.typescript-best-practices,poteto-mode, andmake-bot-uiall load under those folder names.A model turn did not run.
grok -p '/poteto-mode say ok' --max-turns 1exited 1: not signed in, andXAI_API_KEYis unset.