Repository navigation
Expose FloatErrorKind - #164794
Merged
Merged
Expose FloatErrorKind#164794
Conversation
Collaborator
|
Some changes occurred in float parsing cc @tgross35 |
rustbot
added
S-waiting-on-review
malezjaa
force-pushed
the
extend-float-error-kind
branch
from
October 23, 2026 13:03
7c593ee to
4a0f132
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
|
I think that the @bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
Contributor
|
Also, small procedural thing: accepted ACPs can be closed as soon as the tracking issue is opened; the implementation is nice but not necessary. That's why I closed the ACP before this merged. |
2 of 5 tasks
Contributor
Author
|
It wasn't my ACP, so I couldn't close it myself. I didn't want to bother anyone, so I just linked it using 'Closes #...' ^^ (I hope GitHub can actually close issues between org repos) |
Contributor
|
Ah, I didn't notice that detail, so, makes sense. Either way I resolved that issue. |
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Oct 25, 2026
…r=clarfonthey Expose FloatErrorKind Tracking issue: rust-lang#164793 Closes rust-lang/libs-team#683 (ACP) Right now this only makes the enum public and adds the method, but I'd like more input from libs team on what the `FloatErrorKind` should actually be extended with. r? libs
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Oct 25, 2026
…r=clarfonthey Expose FloatErrorKind Tracking issue: rust-lang#164793 Closes rust-lang/libs-team#683 (ACP) Right now this only makes the enum public and adds the method, but I'd like more input from libs team on what the `FloatErrorKind` should actually be extended with. r? libs
This was referenced Oct 25, 2026
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 25, 2026
…uwer Rollup of 20 pull requests Successful merges: - #163730 (add tests over re-entrancy guarantees for 160776) - #164834 (miri subtree update) - #164849 (Use the span of the doctest code block fence for figuring out the line number) - #164883 (rustdoc: don't panic on a nested use group with no path prefix) - #164890 (Store cold blocks in a bitset instead of a Vec of bools) - #163458 (stabilize {Rc, Arc}::is_unique) - #163499 (vec: stabilise allocators for into_iter) - #163805 (std: check `SO_ERROR` after poll in `TcpStream::connect_timeout`) - #163816 (stabilize String::into_chars) - #163819 (Correct documentation of what `core::ops::Code` is.) - #163847 (add regression test for reborrow-invariant-type) - #164006 (Arduously fix typo) - #164009 (Update `Ready` future expect messages) - #164522 (Add IPv6 hop limit stubs to the motor OS net backend) - #164602 (Improve seek_read_buf_exact() test coverage to match seek_read_exact()) - #164772 (docs: Two nitpick changes to `HashMap`, `BTreeMap` Entry API docs) - #164794 (Expose FloatErrorKind) - #164802 (Migrate stable-specific run-make tests to UI tests) - #164899 (Only recover if we may in `parse_expr_tuple_parens`) - #164903 (rustc-dev-guide subtree update) Failed merges: - #164856 (Switch from `insta` to `expect-test` in bootstrap)
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 26, 2026
Rollup merge of #164794 - malezjaa:extend-float-error-kind, r=clarfonthey Expose FloatErrorKind Tracking issue: #164793 Closes rust-lang/libs-team#683 (ACP) Right now this only makes the enum public and adds the method, but I'd like more input from libs team on what the `FloatErrorKind` should actually be extended with. r? libs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue: #164793
Closes rust-lang/libs-team#683 (ACP)
Right now this only makes the enum public and adds the method, but I'd like more input from libs team on what the
FloatErrorKindshould actually be extended with.r? libs