Repository navigation
rustdoc: don't panic on a nested use group with no path prefix - #164883
Open
sreekaransrinath wants to merge 2 commits into
Open
sreekaransrinath wants to merge 2 commits into
sreekaransrinath wants to merge 2 commits into
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
Thanks for the pull request, and welcome! The Rust Project has assigned @GuillaumeGomez (or someone else) to review your changes, you should hear from them (or someone else) within the next two weeks. Please see the contribution instructions and our LLM policy for more information. Why was this reviewer chosen?The reviewer was selected based on:
|
theemathas
added
the
beta-nominated
Contributor
|
Please also test the following in edition 2015: mod what {
use {*};
} |
GuillaumeGomez
approved these changes
Oct 25, 2026
Member
|
Please add the test as mentioned by @theemathas but otherwise looks good to me. |
sreekaransrinath
added a commit
to sreekaransrinath/rust
that referenced
this pull request
Oct 25, 2026
Cover `mod { use {*}; }` in edition 2015 as requested in rust-lang#164883 review.
This comment has been minimized.
This comment has been minimized.
Cover `mod { use {*}; }` in edition 2015 as requested in review.
sreekaransrinath
force-pushed
the
rustdoc-empty-nested-use
branch
from
October 25, 2026 16:30
ccc2b06 to
71f85a5
Compare
Author
|
added! ty @theemathas @GuillaumeGomez |
Member
|
Thanks! @bors r=theemathas,GuillaumeGomez |
Contributor
|
📌 Commit 71f85a5 has been tentatively approved by It will be put into the queue for this repository once PR CI succeeds. 🌲 The tree is currently closed for pull requests below priority 5. This pull request will be tested once the tree is reopened. Reason for tree closure: |
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Oct 25, 2026
…ted-use, r=theemathas,GuillaumeGomez rustdoc: don't panic on a nested use group with no path prefix fixes rust-lang#164158 rustdoc panicked on a nested use group with no path in front of it, like `use {{}};` or `use {a, {b}};`, because `clean_use_statement` called `unwrap()` on the last segment of a path that had no segments. we now check the last segment with `is_some_and` instead, so the `self` handling only runs when there's a segment to look at the new test covers `use {{}};` and the nested shape from the crater run. i ran it locally and it panics at the same line without the fix and passes with it this is a stable-to-beta regression though, so it may be worth a beta backport
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Oct 25, 2026
…ted-use, r=theemathas,GuillaumeGomez rustdoc: don't panic on a nested use group with no path prefix fixes rust-lang#164158 rustdoc panicked on a nested use group with no path in front of it, like `use {{}};` or `use {a, {b}};`, because `clean_use_statement` called `unwrap()` on the last segment of a path that had no segments. we now check the last segment with `is_some_and` instead, so the `self` handling only runs when there's a segment to look at the new test covers `use {{}};` and the nested shape from the crater run. i ran it locally and it panics at the same line without the fix and passes with it this is a stable-to-beta regression though, so it may be worth a beta backport
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Oct 25, 2026
…ted-use, r=theemathas,GuillaumeGomez rustdoc: don't panic on a nested use group with no path prefix fixes rust-lang#164158 rustdoc panicked on a nested use group with no path in front of it, like `use {{}};` or `use {a, {b}};`, because `clean_use_statement` called `unwrap()` on the last segment of a path that had no segments. we now check the last segment with `is_some_and` instead, so the `self` handling only runs when there's a segment to look at the new test covers `use {{}};` and the nested shape from the crater run. i ran it locally and it panics at the same line without the fix and passes with it this is a stable-to-beta regression though, so it may be worth a beta backport
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #164158
rustdoc panicked on a nested use group with no path in front of it, like
use {{}};oruse {a, {b}};, becauseclean_use_statementcalledunwrap()on the last segment of a path that had no segments.we now check the last segment with
is_some_andinstead, so theselfhandling only runs when there's a segment to look atthe new test covers
use {{}};and the nested shape from the crater run. i ran it locally and it panics at the same line without the fix and passes with itthis is a stable-to-beta regression though, so it may be worth a beta backport