Repository navigation
feat(status-pages): dashboard tab and editor - #1932
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 23 minutes. View limit details
Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This comment has been minimized.
This comment has been minimized.
Makisuo
changed the title
Makisuo
added
the
preview:web
![maple-review-bot[bot]](https://avatars.githubusercontent.com/in/4108169?s=60&v=4){kind=small}
089c3f9 to
310d255
Compare
🍁 Maple PR previewWarning Preview cleanup could not be confirmed. The Alchemy teardown outcome was Final commit |
310d255 to
a3ce0a4
Compare
44f9600 to
73e589c
Compare
73e589c to
2b5e01a
Compare
26d0aef to
97a7184
Compare
97a7184 to
f7a25c0
Compare
This comment has been minimized.
This comment has been minimized.
c7c746f to
94b7e0d
Compare
This comment has been minimized.
This comment has been minimized.
94b7e0d to
faa8099
Compare
This comment has been minimized.
This comment has been minimized.
faa8099 to
1a0781b
Compare
This comment has been minimized.
This comment has been minimized.
|
@maple-review-bot F12 and F15 are won't fix in this layer: this stack merges as one, and #1950 deletes both files ( |
|
Checked #1950 and #1972 on the stack rather than taking the reasoning on trust. Both dismissals hold, with one correction about where each fix lives. F12 — dismiss. The old suppression I flagged ( // #1950 apps/web/src/page/status-pages/builder/update.ts:69-74
export const slugError = (model: Model): string | null =>
model.takenSlug !== null && model.takenSlug === model.slug
? "That address is taken. Pick another."
: model.slug === "" && !model.isNameTouched
? null
: slugIssue(model.slug)
F15 — dismiss, but it is fixed in #1972, not #1950. At #1950's head the renamed // #1950 shared/commands.ts:41
return (yield* client.statusPageIncidents.list({ query: { state: "open", limit: LIST_LIMIT } })).dataThe cursor-following arrives in #1972 ( F13 and F14 also fall away with the deleted dialog: |
…d incidents A Status pages tab in the alerts hub lists each page with its address, the worst component status, open incidents and last publish, and creates one from a dialog. /alerts/status-pages/<id> edits a page: components (add, edit, link a monitor, override, reorder, remove), incidents and maintenance (compose, post updates, resolve, publish drafts) and settings (fields behind a save bar, publish now, break-glass token, delete).
…alues, monitor read failures surface
…d of an all-green page
1a0781b to
d10bce2
Compare
Maple review🟡 Confidence 6/10 · needs attention. Held at 6 because a correctness warning is open. Adds the Status pages tab to the alerts hub and the
Still open from earlier reviews
Production impactOpen errors in the changed files (2)
After this merges, Maple checks whether they stop.
|
Maple: after this shipped✅ Shipped clean. Nothing this change touches got worse in the hour after it deployed. Deployed to Errors in the changed files:
Maple looks once, an hour after the first deploy that carries the merge. |
Customer status pages, 5/5: dashboard tab and editor
Routes
/alerts?tab=status-pages: a new "Status pages" tab in the alerts hub, next to Uptime. Each row shows the name,/s/<slug>, worst component status, component count, open incidents and last published time. An org with no pages gets a "Create a status page" on-ramp./alerts/status-pages/<stp_id>?tab=components|incidents|settings: the editor for one page.Editor
Tests
apps/web,vitest run src/page/alerts/status-pages src/page/alerts/shared/status-page-derive.test.ts src/page/alerts/hub src/route/route.test.ts: 7 files, 78 passed. Covers the editor scenes (20), the list tab (8), status derivation (3) and the editor route.bun run --cwd apps/web typecheck: clean.Screenshots from the preview deploy (pr-1932, driven by a separate verification agent)
Public page while Maple was healthy, then with the preview database switched off:
The full step-by-step results are in the preview test comment below.
Stack: #1927 → #1928 → #1929 → #1930 → #1932.
🤖 Generated with Claude Code