Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cc/refactor/cdr-legacy-retirement #4387 +/- ##
==================================================================
Coverage 74.07% 74.08%
==================================================================
Files 1746 1746
Lines 177219 177219
Branches 16506 16506
==================================================================
+ Hits 131281 131287 +6
+ Misses 42485 42476 -9
- Partials 3453 3456 +3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This was referenced Oct 1, 2026
This was referenced Oct 1, 2026
TomCC7
removed this pull request from stack #4372
October 6, 2026 07:56
TomCC7
force-pushed
the
cc/feat/cdr-episode-status
branch
from
October 15, 2026 07:34
c7aef02 to
39030fe
Compare
TomCC7
force-pushed
the
cc/refactor/cdr-legacy-retirement
branch
from
October 15, 2026 07:34
d6934a7 to
a1c7ab8
Compare
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Independent EpisodeStatus proposal; not a member of the CDR native stack. Base remains #4371. The CDR stack now ends at #4445; this PR stays open with its code and review history preserved.
Add the built-in
dimos_msgs/msg/EpisodeStatusvalue type, following the existing message generation workflow. The fields follow the robot-learning model; this does not migrate its JSON collector.Short Python usage guide.
[]/[""]preserve None/empty labels; signed counters have int64 wire bounds. Applications enforce finite timestamps and enum spellings; generated values do not reproduce Pydantic required-input/coercion rules or its JSON envelope.Final parent-relative diff: one definition (12 lines), one guide (40 lines), and 13 standard generated files (+200 lines). The generated files expose the type in Python/C++/Rust and package its schemas/exports; the existing alignment check requires them together. No dedicated tests, worker/native examples, Cargo files, CI/workflow changes or generator/build-core edits remain. The updated #4371 parent retains original legacy message APIs; this branch incorporates it with a normal merge. EpisodeStatus's parent-relative scope remains unchanged.
Validation at
d13d038f550ffadd079b9d8f0382b524e12c0aa5: existing generation--checkPASS; existing definition/stub/alignment tests 28 PASS; embedded Python usage block PASS; required hooks PASS. Prior broader CI results belong to earlier heads and are not presented as this cleanup's results.Current published HEAD:
c7aef022873a03fb5ff5b4b06bbcd5a7cd3aa7f1. Base #4371:9a2f0e8dbb89001b3db60e1358326aa9b4bcfe44. The 15-file +252-line EpisodeStatus diff is preserved; original legacy and generated CDR round-trips pass in this checkout. Earlier validation above remains pinned to its original HEAD; no new CI queried.