Skip to content

feat(msgs): add EpisodeStatus - #4387

Draft
TomCC7 wants to merge 8 commits into
cc/refactor/cdr-legacy-retirementfrom
cc/feat/cdr-episode-status
Draft

TomCC7 wants to merge 8 commits into
cc/refactor/cdr-legacy-retirementfrom
cc/feat/cdr-episode-status

Conversation

@TomCC7

@TomCC7 TomCC7 commented Oct 1, 2026 •

Copy link
Copy Markdown
Member

Independent EpisodeStatus proposal; not a member of the CDR native stack. Base remains #4371. The CDR stack now ends at #4445; this PR stays open with its code and review history preserved.

Add the built-in dimos_msgs/msg/EpisodeStatus value type, following the existing message generation workflow. The fields follow the robot-learning model; this does not migrate its JSON collector.

float64 ts
string state
int64 episodes_saved
int64 episodes_discarded
string last_event "init"
string[<=1] task_label
uv run python -m scripts.generate_builtin_messages
uv run python -m scripts.generate_builtin_messages --check

Short Python usage guide. []/[""] preserve None/empty labels; signed counters have int64 wire bounds. Applications enforce finite timestamps and enum spellings; generated values do not reproduce Pydantic required-input/coercion rules or its JSON envelope.

Final parent-relative diff: one definition (12 lines), one guide (40 lines), and 13 standard generated files (+200 lines). The generated files expose the type in Python/C++/Rust and package its schemas/exports; the existing alignment check requires them together. No dedicated tests, worker/native examples, Cargo files, CI/workflow changes or generator/build-core edits remain. The updated #4371 parent retains original legacy message APIs; this branch incorporates it with a normal merge. EpisodeStatus's parent-relative scope remains unchanged.

Validation at d13d038f550ffadd079b9d8f0382b524e12c0aa5: existing generation --check PASS; existing definition/stub/alignment tests 28 PASS; embedded Python usage block PASS; required hooks PASS. Prior broader CI results belong to earlier heads and are not presented as this cleanup's results.

Current published HEAD: c7aef022873a03fb5ff5b4b06bbcd5a7cd3aa7f1. Base #4371: 9a2f0e8dbb89001b3db60e1358326aa9b4bcfe44. The 15-file +252-line EpisodeStatus diff is preserved; original legacy and generated CDR round-trips pass in this checkout. Earlier validation above remains pinned to its original HEAD; no new CI queried.

@TomCC7
TomCC7 added this pull request to stack #4372 October 1, 2026 23:22
@codecov

codecov Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

@@                        Coverage Diff                         @@
##           cc/refactor/cdr-legacy-retirement    #4387   +/-   ##
==================================================================
  Coverage                              74.07%   74.08%           
==================================================================
  Files                                   1746     1746           
  Lines                                 177219   177219           
  Branches                               16506    16506           
==================================================================
+ Hits                                  131281   131287    +6     
+ Misses                                 42485    42476    -9     
- Partials                                3453     3456    +3     
Components Coverage Δ
Tests 84.87% <ø> (ø)
Flag Coverage Δ
OS-ubuntu-24.04-arm 77.12% <ø> (-0.02%) ⬇️
OS-ubuntu-latest 77.91% <ø> (+<0.01%) ⬆️
Py-3.10 77.66% <ø> (+0.01%) ⬆️
Py-3.11 77.89% <ø> (+0.01%) ⬆️
Py-3.12 77.87% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@TomCC7 TomCC7 closed this Oct 1, 2026
@TomCC7 TomCC7 reopened this Oct 1, 2026
@TomCC7 TomCC7 changed the title feat(msgs): add EpisodeStatus built-in authoring sanity check feat(msgs): add EpisodeStatus Oct 2, 2026
@TomCC7 TomCC7 changed the title feat(msgs): add EpisodeStatus feat(msgs): add EpisodeStatus (8/8) Oct 2, 2026
@TomCC7
TomCC7 removed this pull request from stack #4372 October 6, 2026 07:56
@TomCC7 TomCC7 changed the title feat(msgs): add EpisodeStatus (8/8) feat(msgs): add EpisodeStatus Oct 6, 2026
@TomCC7
TomCC7 force-pushed the cc/feat/cdr-episode-status branch from c7aef02 to 39030fe Compare October 15, 2026 07:34
@TomCC7
TomCC7 force-pushed the cc/refactor/cdr-legacy-retirement branch from d6934a7 to a1c7ab8 Compare October 15, 2026 07:34

This branch had an error being deployed

1 failed (outdated) deployment
cachix — 39030fe9 Deployed Oct 15, 2026 by TomCC7 via cachix-build #12998
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant